Probe re-org #294
Probe re-org #294
Conversation
- tag/weave* -> package overlay - tag/origin_host* -> package host - tag/topology* -> package main
peterbourgon
force-pushed
the
probe-reorg
branch
from
87016df to
f4b3930
Compare
| // on the host machine, at the granularity of host and port. That information | ||
| // is stored in the Endpoint topology. It optionally enriches that topology | ||
| // with process (PID) information. | ||
| func NewReporter(hostID, hostName string, includeProcesses bool) *Reporter { |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
Do you know why coverage has gone down so much? |
|
I don't! I didn't remove any tests... I can add some more tests to bump the metric back up, if you think it's important. Or we can file another issue to work on coverage specifically. |
| @@ -80,16 +80,16 @@ func main() { | |||
| ) | |||
|
|
|||
| var ( | |||
| weaveTagger *tag.WeaveTagger | |||
| weave *overlay.Weave | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
Nah the coverage isn't worth it for the sake of it, although we had just got it over 70%... |
peterbourgon
force-pushed
the
probe-reorg
branch
from
0f0cb9d to
da9f01d
Compare
| @@ -149,7 +149,7 @@ func applyNAT(rpt report.Report, scope string) error { | |||
| func conntrackModulePresent() bool { | |||
| f, err := os.Open(modules) | |||
| if err != nil { | |||
| log.Printf("conntrack error: %v", err) | |||
| //log.Printf("conntrack error: %v", err) // /proc doesn't exist on Darwin | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
Looks much nicer now. LGTM with that one comment. |
peterbourgon
force-pushed
the
probe-reorg
branch
from
da9f01d to
d9a37df
Compare
Closes #238