Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorg probe code #238

Closed
tomwilkie opened this issue Jun 16, 2015 · 4 comments
Closed

Reorg probe code #238

tomwilkie opened this issue Jun 16, 2015 · 4 comments
Assignees
Milestone

Comments

@tomwilkie
Copy link
Contributor

Ideas:

  • directory per data source (docker, process, endpoints)
  • tagger interface & topology generating interface.
  • break up the docker tagger into different responsibilities.
@peterbourgon peterbourgon added this to the postdocker milestone Jun 16, 2015
@tomwilkie
Copy link
Contributor Author

As part of #237 I moved all the docker code into probe/docker, and introduced a Reporter interface. I think we can make everything either a Tagger or a Reporter.

@tomwilkie
Copy link
Contributor Author

Thought: we could introduce a "process" module, and disaggregate pidtree into a process walker, a pidtree implementation (using the walker), and a process reporter (using the walker)

@tomwilkie
Copy link
Contributor Author

#270 reorganised the process module.

@tomwilkie
Copy link
Contributor Author

I think all thats left is to:

  • give the weave tagger a similar treatment (weave module, separate tagger and reporter)
  • consider moving origin_host_tagger into host module

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants