Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use timestamp in URL #2919

Merged
merged 1 commit into from
Nov 14, 2017
Merged

Use timestamp in URL #2919

merged 1 commit into from
Nov 14, 2017

Conversation

fbarl
Copy link
Contributor

@fbarl fbarl commented Nov 1, 2017 •
edited
Loading

Fixes #2823.

Changes
  • Store the pausedAt value in the URL (as timestamp field), effectively storing the Time Travel state.
  • Use a fallback mechanism to go into the paused state at the current timestamp if Time Travel functionality is not provided (which is the case for the typical standalone Scope setup).
  • Bump the Time Travel component version and forward it timestamps as formatted strings.
  • Don't go out of Time Travel mode when unmounting the UI.
  • Empty version field state is now null instead of ... for state tree consistency.

@fbarl fbarl self-assigned this Nov 1, 2017
@fbarl
Copy link
Contributor Author

fbarl commented Nov 1, 2017

Use Scope timestamp in URL

@fbarl fbarl force-pushed the 2823-include-timestamp-in-url branch 2 times, most recently from 3613782 to c473a15 Compare November 10, 2017 15:43
@fbarl fbarl force-pushed the 2823-include-timestamp-in-url branch from c473a15 to 4bd7fc7 Compare November 10, 2017 15:47
@fbarl fbarl changed the title [WIP] Use timestamp in URL Use timestamp in URL Nov 10, 2017
@fbarl fbarl requested a review from jpellizzari November 10, 2017 15:50
@fbarl fbarl mentioned this pull request Nov 13, 2017
Merged
@fbarl fbarl requested a review from aaron7 November 13, 2017 13:41
@fbarl fbarl merged commit bf78fc5 into master Nov 14, 2017
@dlespiau dlespiau deleted the 2823-include-timestamp-in-url branch November 21, 2017 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaron7 aaron7 aaron7 approved these changes

@jpellizzari jpellizzari Awaiting requested review from jpellizzari

Assignees

@fbarl fbarl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fbarl @aaron7