Upgrade to React 16 #2929
Merged
Upgrade to React 16 #2929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaron7
force-pushed
the
react-16
branch
3 times, most recently
from
e926062 to
8d5bda4
Compare
fbarl
reviewed
Nov 13, 2017
client/package.json
Outdated
| "styled-components": "^2.2.1", | ||
| "weaveworks-ui-components": "git+https://github.com/weaveworks/ui-components.git#v0.1.51", | ||
| "styled-components": "2.2.1", | ||
| "weaveworks-ui-components": "git+https://github.com/weaveworks/ui-components.git#v0.2.0", |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
I pushed a commit that fixes two warnings I was getting:
Other thing is that part of debug toolbar panel seems to be broken, but that wasn't introduced in this branch. @aaron7 please take a quick look at my last commit, the rest LGTM! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
weaveworks-ui-componentsto 0.2.0 with React 16 supportnowInSecondsPrecisionas it was removed in https://github.com/weaveworks/ui-components/pull/59/filesreact-addons-perfin debug toolbar as it is no longer supported in React 16