-
Notifications
You must be signed in to change notification settings - Fork 712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust timeline zoom sensitivity on Firefox #2777
Conversation
006f81f
to
83e433e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really difficult to test this on FF. Both master
and this branch have a baseline of 75% CPU use. The adjustment seems to help with zoom sensitivity but is overshadowed by general lag. Is it just my machine?
The zoom track still seems a bit excessive. What do you hope to learn? If it's binary use vs non-use, maybe use some once
logic, or otherwise massively turn up the debounce interval (request handling eats into drawing performance).
FWIW Chrome works perfectly fine.
I recommend changing the tracking, then merge this, and then do profiling for FF in a separate PR.
The FF performance is probably #2302. |
I hope to see at which depth the users are using the timeline, i.e. whether they are more interested in moving through minutes/hours/days/etc... With that in mind, I will increase |
83e433e
to
5692429
Compare
Nah, it can hardly have gotten worse ;) |
Resolves #2768 by taking the
defaultWheelDelta
logic from https://github.com/d3/d3-zoom.Zooming transitions were made also animated to make them smoother (especially on Firefox which sometimes does discrete jumps).
Edit: Tracking of zoom events was wrapped into a debounce method to prevent excessive Mixpanel reporting.