Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gather Weave Net plugin and proxy info from report #2719

Merged
merged 1 commit into from
Jul 18, 2017

Conversation

2opremio
Copy link
Contributor

Instead of using Docker, because after Weave Net 2.0 there are no proxy nor
plugin containers.

This has the drawback of not detecting the plugin/proxy in systems running
Weave Net < 2.0 , but I think we can live with it.

Fixes #2634

Instead of using Docker, because after Weave Net 2.0 there are no proxy nor
plugin containers.

This has the drawback of not detecting the plugin/proxy in systems running
Weave Net < 2.0 , but I think we can live with it.
@2opremio 2opremio requested a review from rade July 17, 2017 13:32
@rade rade requested a review from bboreham July 17, 2017 13:40
Copy link
Member

@rade rade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rade
Copy link
Member

rade commented Jul 17, 2017

@2opremio did you check that this gets rid of the docker daemon log entries shown in #2628? Both for Weave Net 2.0 and pre-2.0 (not essential, but would be lovely).

@2opremio
Copy link
Contributor Author

did you check that this gets rid of the docker daemon log entries shown

Yes it does.

@2opremio 2opremio merged commit 57f2e6a into master Jul 18, 2017
@2opremio 2opremio deleted the update-weave-client-to-2.0 branch July 18, 2017 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants