Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scope needs updating for Weave Net 2.0 #2634

Closed
bboreham opened this issue Jun 22, 2017 · 3 comments
Closed

Scope needs updating for Weave Net 2.0 #2634

bboreham opened this issue Jun 22, 2017 · 3 comments
Assignees
Labels
chore Related to fix/refinement/improvement of end user or new/existing developer functionality estimate/hours It will take less than 8 hours to implement
Milestone

Comments

@bboreham
Copy link
Collaborator

This code: https://github.com/weaveworks/scope/blob/master/probe/overlay/weave.go
It's attempting to talk to a weaveproxy container, which no longer exists.

@bboreham bboreham added chore Related to fix/refinement/improvement of end user or new/existing developer functionality estimate/hours It will take less than 8 hours to implement labels Jun 22, 2017
@rade
Copy link
Member

rade commented Jun 22, 2017

This is a problem already since in a CNI context the proxy won't be running. Nor will the plugin. Cue lots of log noise that terrifies users - see #2628.

@rade
Copy link
Member

rade commented Jul 5, 2017

Would it be reasonable to simply remove the plugin and proxy stuff from that code?

@rade
Copy link
Member

rade commented Jul 5, 2017

Actually, I guess we should obtain the info from the Weave Net 2.0 status json, since it's included there now. I don't think we should bother keeping the existing code for old Weave Net versions, especially since, as observed above, it can generate log noise there too. We should however make sure that the new status retrieval code can cope with an old version json.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Related to fix/refinement/improvement of end user or new/existing developer functionality estimate/hours It will take less than 8 hours to implement
Projects
None yet
Development

No branches or pull requests

3 participants