Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow disabling of weaveDNS advertising/lookup #2445

Merged
merged 1 commit into from
Apr 15, 2017
Merged

Conversation

rade
Copy link
Member

@rade rade commented Apr 14, 2017

...while keeping other weave integrations, by setting --weave.hostname=

Addresses a suggestion in #1550.

...while keeping other weave integrations, by setting
--weave.hostname=

Addresses a suggestion in #1550.
@rade rade requested a review from ekimekim April 14, 2017 23:06
@rade
Copy link
Member Author

rade commented Apr 14, 2017

There is a change in behaviour here, beyond the explicit intention of this PR, in what value we attempt to register/lookup in DNS. This is a) is unlikely to be relied on by existing users, and b) hard to eliminate:

weave.hostname {app,probe}.weave.hostname master branch
unset unset scope.weave.local scope.weave.local
unset = scope.weave.local
= unset scope.weave.local
unset =y y y
=x unset x x
= =
=x = x x
= =y y y
=x =y x y

Copy link
Contributor

@ekimekim ekimekim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I agree it's very unlikely anyone was relying on that behaviour, and even if they are it's a simple fix.

@rade rade merged commit 5c452d0 into master Apr 15, 2017
@rade rade deleted the 1550-disable-weave-dns branch July 5, 2017 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants