Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

show container connections w/o proc scraping #1550

Closed
tomwilkie opened this issue Jun 3, 2016 · 4 comments
Closed

show container connections w/o proc scraping #1550

tomwilkie opened this issue Jun 3, 2016 · 4 comments
Labels
feature Indicates that issue is related to new end user functionality

Comments

@tomwilkie
Copy link
Contributor

tomwilkie commented Jun 3, 2016 •
edited
Loading

Situation:

  • run k8s anywhere (which uses CNI for pods)
  • run scope as a probe daemon set / app replication controller
  • turn off proc scraping (--probe.processes=false)

Result:

  • No edges
@tomwilkie tomwilkie self-assigned this Jun 3, 2016
@tomwilkie
Copy link
Contributor Author

tomwilkie commented Jun 4, 2016 •
edited
Loading

What was happening: Containers started via CNI have --net=none, so the docker reporter does not know about IP addresses; hence the rendering join-on-ip for conntracked connections fails.

Also, I have --probe.weave.addr=, which disables the probe running weave ps. Enabling that restore the edges. Crisis adverted.

@tomwilkie
Copy link
Contributor Author

We could consider decoupling the weavedns lookups from --probe.weave.addr=, and also consider using the golang weave ps implementation.

@tomwilkie tomwilkie removed their assignment Jun 4, 2016
@tomwilkie tomwilkie mentioned this issue Jun 4, 2016
Merged
@rade rade added the k8s Pertains to integration with Kubernetes label Jul 4, 2016
@rade rade mentioned this issue Jul 4, 2016
Closed
@rade rade added the bug Broken end user or developer functionality; not working as the developers intended it label Jul 4, 2016
@rade rade added the accuracy Incorrect information is being shown to the user; usually a bug label Jan 11, 2017
@2opremio 2opremio mentioned this issue Jan 27, 2017
Open
@rade rade changed the title Scope/kubernetes/CNI doesn't get IPs for containers and therefore conntracked edges are missing edges missing when disabling proc scraping and weave net integration Apr 14, 2017
rade added a commit that referenced this issue Apr 14, 2017
@rade
allow disabling of weaveDNS advertising/lookup
413dbc7 
...while keeping other weave integrations, by setting
--weave.hostname=

Addresses a suggestion in #1550.
@rade rade mentioned this issue Apr 14, 2017
Merged
@rade rade changed the title edges missing when disabling proc scraping and weave net integration show container connections w/o proc scraping Apr 14, 2017
@rade rade added feature Indicates that issue is related to new end user functionality and removed accuracy Incorrect information is being shown to the user; usually a bug bug Broken end user or developer functionality; not working as the developers intended it k8s Pertains to integration with Kubernetes labels Apr 14, 2017
@rade
Copy link
Member

rade commented Apr 14, 2017

We could consider decoupling the weavedns lookups from --probe.weave.addr=

These days there's a weaveEnabled flag. There isn't a clean way to only disable the dns registration / lookup; I am fixing that in #2445.

use the golang weave ps implementation.

We are calling weave.PS() i.e. using the weave client library. ATM that does end up executing weave --local ps, which in turn invokes weaveutil container-addrs ... with the result of docker ps -q. container-addrs in turn calls the docker client API to do an inspect on each of the containers.

So there's quite a lot going on, and some optimisations are certainly possible, but these should all be hidden behind weave.PS(), so there's no work to do in the scope code base.

The rest of this issue then is a feature request: show edges between containers w/o proc scraping. This should be possible in principle since we can obtain the container IPs from docker regardless of the network implementation.

@bboreham
Copy link
Collaborator

bboreham commented Jun 8, 2018

The meat of this issue was fixed by #3207. Unfortunately it's still not good enough, but #2586 can stand to cover that.

@bboreham bboreham closed this as completed Jun 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature Indicates that issue is related to new end user functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rade @tomwilkie @bboreham