-
Notifications
You must be signed in to change notification settings - Fork 712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
eBPF proc fallback #2327
Merged
2opremio
merged 4 commits into
weaveworks:master
from
kinvolk-archives:schu/ebpf-proc-fallback
Mar 14, 2017
Merged
eBPF proc fallback #2327
2opremio
merged 4 commits into
weaveworks:master
from
kinvolk-archives:schu/ebpf-proc-fallback
Mar 14, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schu
force-pushed
the
schu/ebpf-proc-fallback
branch
2 times, most recently
from
March 14, 2017 10:17
986c761
to
24d5337
Compare
schu
force-pushed
the
schu/ebpf-proc-fallback
branch
from
March 14, 2017 10:56
24d5337
to
f2dcbcc
Compare
Updated. |
Fixes #2215 |
2opremio
reviewed
Mar 14, 2017
probe/endpoint/connection_tracker.go
Outdated
return noopConnectionTracker | ||
// ebpf failed, fallback to conntrack for connection tracking | ||
log.Warnf("Error setting up the eBPF tracker: %v", err) | ||
log.Warnf("Fallback to proc scanning") |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
LGT minor-comment aside |
schu
force-pushed
the
schu/ebpf-proc-fallback
branch
from
March 14, 2017 13:00
f2dcbcc
to
21047dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not ready for merge yet, requires