scope: use same Docker args for early dry run #2326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We want to do something like to test the fallback for #2215 Currently, that's not possible due to dry run with |
|
cc @alban |
|
I am thinking that, instead, it may be better to simply dry-run with the exact same docker arguments as launch (privileges and all). In that way we will detect more problems early. Thoughts? |
Sound ok to me, will prepare a fixup to do that. |
`launch` first does a `scope --dry-run` to parse and validate Scope cmdline arguments before starting the main Scope container and processes. Use the same Docker args for the dry run to make sure the container has the same privileges and mount points. Otherwise valid `$WEAVESCOPE_DOCKER_ARGS` might fail here.
schu
force-pushed
the
schu/scope-dry-run
branch
from
7f05f42 to
5f85256
Compare
|
Updated. |
|
LGTM, please update the PR title |
schu
changed the title
WEAVESCOPE_DOCKER_ARGS in dry run
|
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
launchfirst does ascope --dry-runto parse and validate Scopecmdline arguments before starting the main Scope container and
processes. Use the same Docker args for the dry run to make sure the
container has the same privileges and mount points. Otherwise valid
$WEAVESCOPE_DOCKER_ARGSmight fail here.