Move truncation of docker ids to FE to allow full value in tooltips #1894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Works well for container topology. On Containers By DNS, I'm not getting the full IDs on tooltips neither in the details panel title nor in the connections table.
Report: https://gist.github.com/davkal/610baf649b64ded6b06dc6a26a3eff99 |
- Reveals full id if you search for it. - Difficult to copy and paste the full id if you want it for some reason
foot
force-pushed
the
1139-untruncate-docker-ids
branch
from
7872e8d to
70681e4
Compare
|
I don't think we're responsible for those ones, I think they're just DNS names chosen w/ a similar truncation heuristic. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1139