Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Container view, detail panel, info table, ID & IMAGE ID fields contain truncated text as tooltip #1139

Closed
pidster opened this issue Mar 7, 2016 · 6 comments
Assignees
Labels
bug Broken end user or developer functionality; not working as the developers intended it component/ui Predominantly a front-end issue; most/all of the work can be completed by a f/e developer

Comments

@pidster
Copy link
Contributor

pidster commented Mar 7, 2016

Per #1059.
The truncated text is not indicated with '...' and the tooltip is truncated text rather than untruncated text.
Same applies to the image id field.

truncated-tooltip

@davkal
Copy link
Contributor

davkal commented Mar 7, 2016

The ID was truncated in the backend after it was agreed that we show container IDs in the same format as docker ps does.

Please reopen if new reasons exist why we should change this again.

@davkal davkal closed this as completed Mar 7, 2016
@davkal
Copy link
Contributor

davkal commented Mar 7, 2016

For completeness: imageID render issues will be handled in #1058

@rade
Copy link
Member

rade commented Mar 11, 2016

The ID was truncated in the backend after it was agreed that we show container IDs in the same format as docker ps does.

What was the basis of the decision to have the field truncated in the tooltip? And where was that decision recorded? I have searched the issues and PRs but cannot find it. #924 and #930, which introduced this, don't even mention the truncation, let alone the rationale.

Please reopen if new reasons exist why we should change this again.

Unless there is a very good reason, whenever we truncate information, the complete information should be contained in the tooltip.

Btw, note that docker ps has a --no-trunc option.

@rade rade reopened this Mar 11, 2016
@davkal
Copy link
Contributor

davkal commented Mar 12, 2016

What was the basis of the decision to have the field truncated in the tooltip? And where was that decision recorded?

There was no decision. The backend provides one value per field. The frontend renders that value, the browser provides the ellipsis if there is not enough space. The tooltip shows the same field value, but is not shortened by the browser because there is no space restriction.

Unless there is a very good reason, whenever we truncate information, the complete information should be contained in the tooltip.

It's been decided in the last scop sync to remove the backend truncation. Then the full value will arrive in the frontend again: truncated in the field, full in the tooltip.

@davkal davkal added this to the 0.14.0 milestone Mar 12, 2016
@tomwilkie tomwilkie removed this from the 0.14.0 milestone Mar 17, 2016
@rade rade added bug Broken end user or developer functionality; not working as the developers intended it component/ui Predominantly a front-end issue; most/all of the work can be completed by a f/e developer labels Jul 4, 2016
@rade rade added this to the August2016 milestone Aug 16, 2016
@foot
Copy link
Contributor

foot commented Aug 24, 2016

Anyone know the commit/issue/pr where the truncation was introduced?

@rade
Copy link
Member

rade commented Sep 13, 2016

Anyone know the commit/issue/pr where the truncation was introduced?

See my comment above from a few months ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Broken end user or developer functionality; not working as the developers intended it component/ui Predominantly a front-end issue; most/all of the work can be completed by a f/e developer
Projects
None yet
Development

No branches or pull requests

5 participants