fix inbound internet connections counts #1868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remoteAddr was never being set - localAddr is part of the localNodeID in all the cases it was set, so it effectively was part of the key twice
Instead of including the localEndpointID in the key, use the address, so the port is excluded. That way we don't end up with multiple rows for inbound connections from the same internet address. We also augment the address with the DNS info here, which saves us from having to look it up later on. Fixes #1867
2opremio
suggested changes
Sep 19, 2016
| @@ -149,7 +149,7 @@ func TestMakeDetailedHostNode(t *testing.T) { | |||
| Columns: detailed.NormalColumns, | |||
| Connections: []detailed.Connection{ | |||
| { | |||
| ID: fmt.Sprintf("%s:%s-%s:%s-%d", fixture.ServerHostNodeID, "", fixture.ClientHostNodeID, "", 80), | |||
| ID: fmt.Sprintf("%s-%s-%d", fixture.ServerHostNodeID, "", 80), | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
rade
force-pushed
the
1867-inbound-internet-connections-counts
branch
from
a0bef49 to
591e72e
Compare
2opremio
approved these changes
Sep 19, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1867.