Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inbound internet connection counts are too fine-grained #1867

Closed
rade opened this issue Sep 15, 2016 · 0 comments
Closed

inbound internet connection counts are too fine-grained #1867

rade opened this issue Sep 15, 2016 · 0 comments
Assignees
@rade
Labels
bug Broken end user or developer functionality; not working as the developers intended it
Milestone
1.0.0 (kubecon)

Comments

@rade
Copy link
Member

rade commented Sep 15, 2016

screenshot from 2016-09-15 11-21-43
The two connections are from the same address, so we should only have one row, with a count of 2.

This happens because the counter key for internet connections contains the endpoint id, which includes the port. That is fine for outbound internet connections, since there we do care about the port (though it's redundant, since the port is also part of the key directly). But not for inbound internet connections.
@rade rade added the bug Broken end user or developer functionality; not working as the developers intended it label Sep 15, 2016
@rade rade added this to the 0.18/1.0 milestone Sep 15, 2016
@rade rade self-assigned this Sep 15, 2016
rade added a commit that referenced this issue Sep 15, 2016
@rade
key internet node connection counts differently
0e1aeec 
Instead of including the localEndpointID in the key, use the
address, so the port is excluded. That way we don't end up with multiple
rows for inbound connections from the same internet address.

We also augment the address with the DNS info here, which saves us from
having to look it up later on.

Fixes #1867
@rade rade mentioned this issue Sep 15, 2016
Merged
rade added a commit that referenced this issue Sep 19, 2016
@rade
Merge pull request #1868 from weaveworks/1867-inbound-internet-connec…
7b0f0cb 
…tions-counts

fix inbound internet connections counts

Fixes #1867.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rade rade

Labels
bug Broken end user or developer functionality; not working as the developers intended it
Projects
None yet
Milestone
1.0.0 (kubecon)
Development

No branches or pull requests
1 participant
@rade