Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Elide service-token when logging commandline arguments #1782

Merged
merged 2 commits into from
Aug 11, 2016
Merged

Elide service-token when logging commandline arguments #1782

merged 2 commits into from
Aug 11, 2016

Conversation

2opremio
Copy link
Contributor

Fixes #1779

rade
rade reviewed Aug 11, 2016
View reviewed changes
prog/main.go
@@ -119,6 +121,25 @@ type appFlags struct {
consulInf string
}

func logCensoredArgs() {
var prettyPrintedArgs string
// we show the args followed by the flags which is likely to change the

This comment was marked as abuse.

Sign in to view

This comment was marked as abuse.

Sign in to view

@rade
Copy link
Member

rade commented Aug 11, 2016

LGTM

@2opremio 2opremio merged commit 2243461 into master Aug 11, 2016
@2opremio 2opremio deleted the 1779-elide-service-token branch August 11, 2016 16:12
@2opremio 2opremio mentioned this pull request Mar 21, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@2opremio @rade