Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not log service tokens #1779

Closed
2opremio opened this issue Aug 10, 2016 · 2 comments
Closed

Do not log service tokens #1779

2opremio opened this issue Aug 10, 2016 · 2 comments
Assignees
@2opremio
Labels
bug Broken end user or developer functionality; not working as the developers intended it
Milestone
0.17.0

Comments

@2opremio
Copy link
Contributor

We log all of Scope's comnand line arguments ... including the service token and users share logs to diagnose problems, which is a horrible combination (security wise).
@2opremio 2opremio added the chore Related to fix/refinement/improvement of end user or new/existing developer functionality label Aug 10, 2016
@2opremio 2opremio self-assigned this Aug 10, 2016
@2opremio 2opremio added this to the July2016 milestone Aug 10, 2016
@rade rade added bug Broken end user or developer functionality; not working as the developers intended it and removed chore Related to fix/refinement/improvement of end user or new/existing developer functionality labels Aug 10, 2016
@rade
Copy link
Member

rade commented Aug 10, 2016

NB: this issue was prompted by a user posting their weavescope logs on a public slack channel.

@rade
Copy link
Member

rade commented Aug 10, 2016

Weave Net logs command line args too but filters out sensitive info.

@2opremio 2opremio mentioned this issue Aug 11, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@2opremio 2opremio

Labels
bug Broken end user or developer functionality; not working as the developers intended it
Projects
None yet
Milestone
0.17.0
Development

No branches or pull requests
2 participants
@rade @2opremio