Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add arrow heads to edges #872

Closed
tomwilkie opened this issue Jan 28, 2016 · 6 comments
Closed

Add arrow heads to edges #872

tomwilkie opened this issue Jan 28, 2016 · 6 comments
Assignees
Labels
component/ui Predominantly a front-end issue; most/all of the work can be completed by a f/e developer feature Indicates that issue is related to new end user functionality
Milestone

Comments

@tomwilkie
Copy link
Contributor

Feedback from Darren at Rancher.

@tomwilkie tomwilkie added the component/ui Predominantly a front-end issue; most/all of the work can be completed by a f/e developer label Jan 28, 2016
@davkal
Copy link
Contributor

davkal commented Feb 4, 2016

Arrow heads will only look nice, if they end at the outer border of a node. Otherwise the inner node dot will be crowded. For proper arrow offset to end at the border, we need to calculate those endpoints. It's easy for circles, but more tricky for rects with rounded corners.

@pidster
Copy link
Contributor

pidster commented Mar 2, 2016

If edges are directional it makes sense to visualise this for the user to see.
If arrowheads in contact with the node are hard, a V just before the end might work.
Would be worth trying it out.

@tomwilkie
Copy link
Contributor Author

Edges are directional.

On Wednesday, 2 March 2016, Pid [email protected] wrote:

If edges are directional it makes sense to visualise this for the user to
see.
If arrowheads in contact with the node are hard, a V just before the end
might work.
Would be worth trying it out.


Reply to this email directly or view it on GitHub
#872 (comment).

@jml
Copy link
Contributor

jml commented Jun 7, 2016

I didn't realize that "down" meant "connects to". Adding arrowheads (or some sort of symbol for indicating direction) could be quite helpful.

@rade rade added the feature Indicates that issue is related to new end user functionality label Jul 4, 2016
@rade rade modified the milestone: Backlog Jan 11, 2017
@rade rade modified the milestones: 1.3, Backlog Feb 22, 2017
@rade
Copy link
Member

rade commented Feb 22, 2017

Arrow heads will only look nice, if they end at the outer border of a node.

As a (temporary) alternative we could render arrow heads at the mid-point of an edge.

@jpellizzari jpellizzari self-assigned this Feb 22, 2017
@rade
Copy link
Member

rade commented Mar 14, 2017

This can be closed, right?

@rade rade closed this as completed Mar 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/ui Predominantly a front-end issue; most/all of the work can be completed by a f/e developer feature Indicates that issue is related to new end user functionality
Projects
None yet
Development

No branches or pull requests

6 participants