Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

graph not rendered top-down, despite lack of cycles #2267

Closed
rade opened this issue Feb 22, 2017 · 1 comment · Fixed by #2268
Closed

graph not rendered top-down, despite lack of cycles #2267

rade opened this issue Feb 22, 2017 · 1 comment · Fixed by #2268
Assignees
@fbarl
Labels
accuracy Incorrect information is being shown to the user; usually a bug bug Broken end user or developer functionality; not working as the developers intended it component/ui Predominantly a front-end issue; most/all of the work can be completed by a f/e developer

Comments

@rade
Copy link
Member

rade commented Feb 22, 2017

Here's what Weave Cloud Dev shows for the 'cortex' service:

screenshot_2017-02-22_09-29-43

The distributor and ingester are both rendered below consul, even though they connect to consul.

There are no cycles in the directed graph except for the consuls and memcaches connecting to themselves, so there is no intrinsic reason why this couldn't be laid out top-down:

  1. querier, ruler, distributor
  2. ingester
  3. consul, memcached, dynamo, s3
  4. The Internet
@rade rade added bug Broken end user or developer functionality; not working as the developers intended it component/ui Predominantly a front-end issue; most/all of the work can be completed by a f/e developer accuracy Incorrect information is being shown to the user; usually a bug labels Feb 22, 2017
@rade
Copy link
Member Author

rade commented Feb 22, 2017

Fixing #872 would ameliorate this significantly.

@fbarl fbarl self-assigned this Feb 22, 2017
@fbarl fbarl mentioned this issue Feb 22, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fbarl fbarl

Labels
accuracy Incorrect information is being shown to the user; usually a bug bug Broken end user or developer functionality; not working as the developers intended it component/ui Predominantly a front-end issue; most/all of the work can be completed by a f/e developer
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix edge directionality in graph layout weaveworks/scope
2 participants
@rade @fbarl