replace setup.py with poetry #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
anyway, this is the first project that we've had recently that's suitable for playing around with. Sorry for spamming |
|
That seems all fine. Do we then delete the |
|
Installing this with pip from github directly, should just work: python-poetry/poetry#321 (comment) |
tmke8
approved these changes
Feb 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, I've not used poetry to publish to pypi before, but it should be a case of either doing
poetry publish, or adding this as a step to github actions e.g. hereI think that the behaviour of package name
palkit, but dirnamekitshould still be maintained, but without installing from pypi I can't be 100% sure.The only other behaviour that I'm sure poetry has an answer for, but I have no experience of, is installing from github without a setup.py.