-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue partial fix for #44: init pyproject.toml and poetry.lock #50
Conversation
… and runs as expected
… created and runs as expected" ++ I realize deleting setup.py might upset some folks This reverts commit 1a8cfa5.
pyproject.toml
Outdated
name = "opendis" | ||
version = "0.1.0" | ||
description = "" | ||
authors = ["Scott Robertson <[email protected]>"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was a default, we can change this to the original authors of the package.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes let's change to the default authors in setup
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated
Ah, I'm using my system python... tried on fresh machine and there are dependencies:
From RangeCoordinates |
Per https://github.com/numpy/numpy/releases/tag/v1.18.4, the latest version of numpy that supports Python 3.5 is v1.18.4, we'll have to version-lock that dependency to maintain Python 3.5 support |
I'm good with these suggested changes as well. Let's move over values from the setup.py file into the new pyproject.toml file so they match as much as we can. Version, description, etc |
Oldest python version available on my machine appears to be 3.6: https://wiki.archlinux.org/title/python 3.6 and 3.7 are tagged with "unmaintained". Seeing as how this is a DoD spec'ed protocol, shouldn't the community strongly consider upgrading? https://www.cvedetails.com/vulnerability-list/vendor_id-16835/product_id-39445/Numpy-Numpy.html |
Another good point @scottrbrtsn |
Looking good. Is there any benefit to keeping the setup.py if the use of poetry is merged here? |
I'm not 100% on details. Just that it would affect pip install behavior and folks might need adjust accordingly. Similar example: References: |
Ah, this can be tested with:
|
for #44
Problem
There is a desire to become a pip package per Issue 44 linked above. It is recommended to also include a pyproject.toml so package managers like poetry can resolve dependencies. I recognize this is rather trivial to add for open-dis-python seeing as how (after I looked into it) there are virtually no external dependencies to create the package (only
numpy
. Not having apyproject.toml
could affect applications downstream desiring to easily add and manageopendis
as a dependency.However, there is concern with explicitly requiring python versions.
Solution
This PR initializes a pyproject.toml, a poetry lock (for the .venv) and sets the pyproject to use python 3.5 or higher.
Still unresolved
The issue in question could likely:
setup.py
pip install opendis
instead ofgit clone
andpip install .