Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify package generation actions #157

Merged
merged 44 commits into from
Apr 4, 2024
Merged

Conversation

Tostti
Copy link
Member

@Tostti Tostti commented Mar 20, 2024

Description

This PR aims to modify the workflow that generates the Wazuh Dashboard packages.

Evidence

image
Workflow completed
image

The workflow now generates one package at a time. It can have dev or prod nomenclature, and it is possible to upload or not the sha512 of the package.

prod rpm with sha
dev rpm
prod deb
dev deb with sha

If the inputs are invalid, the worklflow will stop and no package will be generated

Invalid inputs

Issues Resolved

#156

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@codecov-commenter
Copy link

codecov-commenter commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.96%. Comparing base (f066302) to head (698cc5b).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##            4.9.0     #157   +/-   ##
=======================================
  Coverage   66.96%   66.96%           
=======================================
  Files        3300     3300           
  Lines       63585    63585           
  Branches    10141    10141           
=======================================
  Hits        42582    42582           
  Misses      18538    18538           
  Partials     2465     2465           
Flag Coverage Δ
Linux_1 35.23% <ø> (ø)
Linux_2 55.16% <ø> (ø)
Linux_3 43.85% <ø> (ø)
Windows_1 35.26% <ø> (ø)
Windows_2 55.13% <ø> (ø)
Windows_3 43.87% <ø> (ø)
Windows_4 35.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tostti Tostti mentioned this pull request Mar 20, 2024
1 task
@Tostti Tostti linked an issue Mar 20, 2024 that may be closed by this pull request
1 task
@rauldpm rauldpm force-pushed the modify-package-generation-actions branch from 724d1fa to acd6429 Compare April 3, 2024 22:51
@Tostti Tostti marked this pull request as ready for review April 4, 2024 11:50
@Tostti Tostti self-assigned this Apr 4, 2024
run: |
cd ${{ env.CURRENT_DIR }}/dev-tools/build-packages
bash ./build-packages.sh \
-v ${{ env.VERSION }} \
-r ${{ env.REVISION }} \
-r ${{ inputs.revision }} \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the revision be the same as the one in the package.json?

Copy link
Member

@yenienserrano yenienserrano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Tostti Tostti merged commit 08e630f into 4.9.0 Apr 4, 2024
106 of 112 checks passed
@Tostti Tostti deleted the modify-package-generation-actions branch April 4, 2024 12:50
Tostti added a commit that referenced this pull request Apr 5, 2024
yenienserrano pushed a commit that referenced this pull request Jun 18, 2024
yenienserrano pushed a commit that referenced this pull request Jul 12, 2024
yenienserrano pushed a commit that referenced this pull request Aug 19, 2024
yenienserrano pushed a commit that referenced this pull request Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update package generation tools
3 participants