Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace direct wat usage with Wasmi's new Module::new Wat support #1327

Merged
merged 21 commits into from
Dec 1, 2024

Conversation

Robbepop
Copy link
Member

@Robbepop Robbepop commented Dec 1, 2024

Follow-up for #1328.

tl;dr: Cleans-up the Wasmi workspace and resolves some tech-debt.

A test-only wat2wasm function has been implemented several times in the Wasmi codebase, especially in tests which is an indicator that this functionality was crucially missing from Wasmi's module parsing.

Copy link

codecov bot commented Dec 1, 2024

Codecov Report

Attention: Patch coverage is 99.43074% with 3 lines in your changes missing coverage. Please review.

Project coverage is 81.68%. Comparing base (c889d43) to head (e87e1b2).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/cli/src/context.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1327      +/-   ##
==========================================
+ Coverage   81.62%   81.68%   +0.06%     
==========================================
  Files         305      307       +2     
  Lines       25287    25261      -26     
==========================================
- Hits        20641    20635       -6     
+ Misses       4646     4626      -20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Robbepop Robbepop changed the title Add optional .wat module parsing to Module::new API Replace direct wat usage with Wasmi's new Module::new Wat support Dec 1, 2024
@Robbepop Robbepop merged commit df21a1a into main Dec 1, 2024
19 checks passed
@Robbepop Robbepop deleted the rf-add-wat-module-parsing branch December 1, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant