Add optional .wat
module support to Module::new
#1328
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A test-only
wat2wasm
function has been implemented several times in the Wasmi codebase, especially in tests which is an indicator that this functionality was crucially missing from Wasmi's module parsing.Thus we added this feature optionally behind the new
wat
crate feature in Wasmi.This also improves Wasmi's Wasmtime API mirroring because Wasmtime also provides
.wat
parsing support in itsModule::new
API.We explicitly do not support
.wat
parsing inModule::new_streaming
since there is no streaming parsing support for.wat
files via the usedwat
crate.