fix(libwaku): support string and int64 for timestamps

[richard-ramos]

The Protocol Buffers JSON Specification for 64 bit numbers, recommends serializing numbers as strings to avoid loss of precision when working with 64-bit integers in JavaScript environments. This causes issues as some json serializers like Go's respect the specification when serializing a protobuffer into Json.
To avoid this issue, in this PR will allow accepting both integers and numeric strings for those cases in which this spec is not followed

[github-actions]

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:3205

Built from c459f4e

[NagyZoltanPeter]

LGTM!
Maybe we could generalize this approach for easy reuse.

[gabrielmer]

LGTM! Thank you!

[richard-ramos]

@NagyZoltanPeter: Maybe we could generalize this approach for easy reuse.

Would something like this work?

import std/[json, strutils]
import results
import ../../../waku/waku_core/time

proc getProtoTimestamp*[T](node: JsonNode, key: string): Opt[T] =
  let (value, ok) =
    if node.hasKey(key):
      if node[key].kind == JString:
        (parseInt(node[key].getStr()), true)
      else:
        (node[key].getBiggestInt(), true)

  if not (T is Timestamp or T is int or T is int64):
    raise newException(ValueError, "Unsupported type")

  return
    if not ok:
      return T.none()
    else:
      when T is Timestamp:
        some(Timestamp(value))
      else:
        some(value)

[NagyZoltanPeter]

@NagyZoltanPeter: Maybe we could generalize this approach for easy reuse.

Would something like this work?

import std/[json, strutils]
import results
import ../../../waku/waku_core/time

proc getProtoTimestamp*[T](node: JsonNode, key: string): Opt[T] =
  let (value, ok) =
    if node.hasKey(key):
      if node[key].kind == JString:
        (parseInt(node[key].getStr()), true)
      else:
        (node[key].getBiggestInt(), true)

  if not (T is Timestamp or T is int or T is int64):
    raise newException(ValueError, "Unsupported type")

  return
    if not ok:
      return T.none()
    else:
      when T is Timestamp:
        some(Timestamp(value))
      else:
        some(value)

Yeah, kind of like that!
Is it only work for Timestamp or can it be named more generic?

[richard-ramos]

@NagyZoltanPeter check the latest commit!
I made it even more generic by returning an int64 instead. I had not realized that Timestamp was an alias for int64

[Ivansete-status]

Awesome! Thanks so much for it! 🙌

[Ivansete-status]

I wonder if we should return a Result instead so that we can better control any possible error

[richard-ramos]

I changed it to a result now. Please do check latest commit and let me know your thoughts!

[NagyZoltanPeter]

I like it! :-)