Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nwaku)_: receive messages via relay #6185

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

richard-ramos
Copy link
Member

@status-im-auto
Copy link
Member

status-im-auto commented Dec 9, 2024

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✖️ 488d526 #1 2024-12-09 22:12:55 ~1 min tests 📄log
488d526 #1 2024-12-09 22:13:35 ~2 min android 📄log
✖️ 488d526 #1 2024-12-09 22:14:18 ~2 min tests-rpc 📄log
488d526 #1 2024-12-09 22:14:22 ~2 min linux 📄log
488d526 #1 2024-12-09 22:14:23 ~2 min ios 📄log
488d526 #1 2024-12-09 22:15:05 ~3 min windows 📄log
488d526 #1 2024-12-09 22:16:17 ~4 min macos 📄log
488d526 #1 2024-12-09 22:16:30 ~5 min macos 📄log
648bff7 #2 2024-12-10 19:41:27 ~1 min linux 📄log
✖️ 648bff7 #2 2024-12-10 19:41:33 ~1 min tests 📄log
648bff7 #2 2024-12-10 19:41:53 ~2 min windows 📄log
648bff7 #2 2024-12-10 19:42:05 ~2 min android 📄log
✖️ 648bff7 #2 2024-12-10 19:42:06 ~2 min tests-rpc 📄log
648bff7 #2 2024-12-10 19:43:36 ~3 min macos 📄log
648bff7 #2 2024-12-10 19:43:38 ~4 min ios 📄log
648bff7 #2 2024-12-10 19:43:54 ~4 min macos 📄log

Copy link

@gabrielmer gabrielmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazingg, thanks so much!

Once it's merged, I'll update waku-go-bindings with the relevant parts

Maybe it would be useful to add a test to make sure message sending works

Copy link
Contributor

@Ivansete-status Ivansete-status left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for it! 💯
I just added a couple of nitpick comments :)

wakuv2/nwaku.go Outdated Show resolved Hide resolved
wakuv2/nwaku.go Outdated Show resolved Hide resolved
@richard-ramos richard-ramos merged commit 387d45d into feature/nwaku-in-status Dec 10, 2024
2 of 10 checks passed
@richard-ramos richard-ramos deleted the feature/relay-nwaku branch December 10, 2024 19:43
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (cc2022b) to head (648bff7).
Report is 1 commits behind head on feature/nwaku-in-status.

Additional details and impacted files
@@               Coverage Diff               @@
##   feature/nwaku-in-status   #6185   +/-   ##
===============================================
===============================================

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants