Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: messageHash attaribute added in PostgreSQL + testcase #2152

Closed
wants to merge 2 commits into from

Conversation

ABresting
Copy link
Contributor

Description

messageHash attributed added to PostgreSQL, which aims to remove the id attribute in upcoming PRs. An associated test case also added.

migration scripts will be changed after the deletion of id attribute in upcoming PRs.

Changes

  • messageHash attribute added
  • added test case to test the messageHash attribute

Issue

#2112

@ABresting ABresting self-assigned this Oct 24, 2023
@ABresting ABresting added the release-notes Issue/PR needs to be evaluated for inclusion in release notes highlights or upgrade instructions label Oct 24, 2023
@github-actions
Copy link

This PR may contain changes to database schema of one of the drivers.

If you are introducing any changes to the schema, make sure the upgrade from the latest release to this change passes without any errors/issues.

Please make sure the label release-notes is added to make sure upgrade instructions properly highlight this change.

Copy link
Collaborator

@Ivansete-status Ivansete-status left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for it! 💯
Just added a minor nitpick comment

@github-actions
Copy link

github-actions bot commented Oct 24, 2023

You can find the image built from this PR at

quay.io/wakuorg/nwaku-pr:2152

Built from c36ceb5

@Ivansete-status Ivansete-status self-requested a review October 24, 2023 14:12
@Ivansete-status
Copy link
Collaborator

LGTM! Thanks for it! 💯 Just added a minor nitpick comment

I disapproved this PR as per the accident we had with SQLite. In this case, we will also need a migration script.
On the other hand, we should postpone this PR, and the Postgres changes as much as possible until we are clear with the SQLite side.

@ABresting ABresting closed this Oct 25, 2023
@ABresting ABresting deleted the add-new-message-hash-column branch October 25, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes Issue/PR needs to be evaluated for inclusion in release notes highlights or upgrade instructions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants