-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add new message_hash column to the archive protocol #2112
Comments
achieved
next
blocker
|
achieved
next
blocking
|
Weekly Update
|
Weekly Update
|
Weekly Update
|
Weekly Update
|
closing this issue since all tasks seem to be done now. |
Problem
We have the
id
column in sqlite and postgres databases that is not unique.Suggested solution (defined by @jm-clius)
Create a unique field,
message_hash
, which will be computed following RFC: https://rfc.vac.dev/spec/14/#deterministic-message-hashing.The
message_hash
will become the PRIMARY KEY.This should also be how the CURSOR gets computed when doing a database lookup. So querying for the next page will become much simpler - find the PRIMARY KEY that matches the CURSOR and query from that point
Drop the current
id
field from the current databases schemas.Acceptance criteria
message_hash
attribute should be present SQLite.message_hash
attribute should be present Postgres.id
column should be ignored and removed from the database schema.Epic
waku-org/pm#57
CC: @chair28980 @fryorcraken
The text was updated successfully, but these errors were encountered: