Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(message_store): move message_store to node module #1342

Merged
merged 2 commits into from
Nov 4, 2022

Conversation

LNSD
Copy link
Contributor

@LNSD LNSD commented Nov 4, 2022

Similar to #1339, this time with the message_store module.

  • Move the message_store module to the node module
  • Decoupled the migrations.migrate() procedure from the peer store's proc and the "shared migrations" module.
  • Used an independent migrations SchemaVersion.
  • Updated the wakunode2 module, the tests, and imports in general accordingly.
  • Removed the common migrations code.

@LNSD LNSD requested review from alrevuelta and jm-clius November 4, 2022 09:07
@LNSD LNSD self-assigned this Nov 4, 2022
@LNSD LNSD force-pushed the refactor-move-message-store branch from 5abf8d2 to c853be4 Compare November 4, 2022 09:12
@status-im-auto
Copy link
Collaborator

status-im-auto commented Nov 4, 2022

Jenkins Builds

Click to see older builds (4)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 5abf8d2 #1 2022-11-04 09:25:31 ~17 min linux 📦bin
✔️ 5abf8d2 #1 2022-11-04 09:25:33 ~17 min macos 📦bin
✔️ c853be4 #2 2022-11-04 09:31:36 ~18 min linux 📦bin
✔️ c853be4 #2 2022-11-04 09:33:27 ~20 min macos 📦bin
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ f091d85 #3 2022-11-04 10:09:51 ~15 min macos 📦bin
✔️ f091d85 #3 2022-11-04 10:10:41 ~16 min linux 📦bin
✔️ f2d8a92 #4 2022-11-04 13:11:00 ~18 min linux 📦bin
✔️ f2d8a92 #4 2022-11-04 13:15:55 ~22 min macos 📦bin

@LNSD LNSD force-pushed the refactor-move-message-store branch from c853be4 to f091d85 Compare November 4, 2022 09:54
@LNSD
Copy link
Contributor Author

LNSD commented Nov 4, 2022

Merging this PR since it solves the node startup issue reported by @jakubgs

@LNSD LNSD merged commit 4509f4f into master Nov 4, 2022
@LNSD LNSD deleted the refactor-move-message-store branch November 4, 2022 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants