refactor(peer_manager): move peer_store under peer_manager module #1339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jm-clius
approved these changes
Nov 4, 2022
| @@ -13,7 +13,7 @@ import | |||
|
|
|||
|
|
|||
| logScope: | |||
| topics = "wakunode.setup.rest" | |||
| topics = "wakunode rest" | |||
There was a problem hiding this comment.
I know not part of this PR, but FWIW I like that the app is just wakunode like here - I'm getting a bit wary of having a confusing 2 everywhere, when we're practically always working with version 2.
There was a problem hiding this comment.
Yes... I also have that concern. To achieve that, we need to coordinate with the infra changes. I have avoided mixing too many infra changes for this release, we are already changing the configuration.
The related issue is: #1002
5 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the work done under #1293, the peer persistence database was decoupled from the message store database connection. This PR continues that work:
peer_storemodule underpeer_managermodule. The code has been collocated with the peer manager code, as it is the only module depending on the peer store.migrations.migrate()procedure from the message store's.SchemaVersionthan the message's store database.wakunode2module, the tests, and imports in general accordingly.