Fix multiple minor styling issues #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Once this is adopted in Wagtail core in the future - we can remove some of the styling overrides in Wagtail docs. |
vsalvino
reviewed
Aug 17, 2022
sphinx_wagtail_theme/theme.conf
Outdated
| @@ -12,5 +12,5 @@ logo_height = 59 | |||
| logo_url = / | |||
| logo_width = 45 | |||
| header_links = | |||
| footer_links = Features|https://wagtail.io/features/, About Wagtail|https://wagtail.io/about-wagtail/, Services|https://wagtail.io/services/, Blog|https://wagtail.io/blog/, Packages|https://wagtail.io/packages/, Developers|https://wagtail.io/developers/ | |||
| footer_links = Features|https://wagtail.org/features/, About Wagtail|https://wagtail.org/about-wagtail/, Services|https://wagtail.org/services/, Blog|https://wagtail.org/blog/, Packages|https://wagtail.org/packages/, Developers|https://wagtail.org/developers/ | |||
There was a problem hiding this comment.
I would think the default here should be empty, and move these footer_links to Wagtail core's docs/conf.py
|
looks like I've accidentally included the links fixes in this PR also - will fix it up. |
- fix gap after content within admonitions, avoid styling every last element inside, only the container - fixes wagtail#107 - use variable for the max-width of the version picker (300px on bootstrap variables) - add layout scss to fix some global style issues (already on Wagtail core) - add .sidebar-container so that we can have a max width on navbar - fixes wagtail#99 - use .sidebar-container to allow for border-right on larger devices to match designs - fixes wagtail#59 - resolve styling issues with sidebar container & overflow scroll - fixes wagtail#190 - avoid using coded styles when bootstrap utility classes are suitable in the sidebar & search box - add high contrast focus outline to focusable (tabbable) elements - fixes wagtail#23
lb-
force-pushed
the
fix/multiple-styling-fixes
branch
from
8954073 to
20354f9
Compare
|
These changes look good to me. I haven't pulled the branch and rendered it, but noticed some of the same issues while poking around for other features. |
|
Thanks - re-validated again and will merge this in. |
This was referenced Aug 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve a range of small styling issues across the documentation