Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase space after admonition code blocks #107

Closed
Stormheg opened this issue Apr 27, 2021 · 4 comments · Fixed by #191
Closed

Increase space after admonition code blocks #107

Stormheg opened this issue Apr 27, 2021 · 4 comments · Fixed by #191
Labels
good first issue Good for newcomers

Comments

@Stormheg
Copy link
Member

https://docs.wagtail.io/en/latest/topics/pages.html#inline-models

I think there should be more space between the code block and the text below it.

image
@lb- lb- added the good first issue Good for newcomers label Mar 30, 2022
@PaarthAgarwal
Copy link
Member

I'm on it.

@PaarthAgarwal
Copy link
Member

I believe this one has been resolved already.
image

@Stormheg
Copy link
Member Author

Looks like the text is now outside the admonition. Perhaps the switch from Recommonmark to MyST (wagtail/wagtail#8074) has something to do with this?

@tbrlpld
Copy link
Collaborator

tbrlpld commented Mar 30, 2022

We should recreate an example where there is text below the code block in an admonition.

lb- pushed a commit to lb-/sphinx_wagtail_theme that referenced this issue Aug 17, 2022
multiple minor styling fixes
8954073 
- fix gap after content within admonitions, avoid styling every last element inside, only the container - fixes wagtail#107
- use variable for the max-width of the version picker (300px on bootstrap variables)
- add layout scss to fix some global style issues (already on Wagtail core)
- add .sidebar-container so that we can have a max width on navbar - fixes wagtail#99
- use .sidebar-container to allow for border-right on larger devices to match designs - fixes wagtail#59
- resolve styling issues with sidebar container & overflow scroll - fixes wagtail#190
- avoid using coded styles when bootstrap utility classes are suitable in the sidebar & search box
- add high contrast focus outline to focusable (tabbable) elements - fixes wagtail#23
@lb- lb- mentioned this issue Aug 17, 2022
Merged
lb- pushed a commit to lb-/sphinx_wagtail_theme that referenced this issue Aug 17, 2022
multiple minor styling fixes
20354f9 
- fix gap after content within admonitions, avoid styling every last element inside, only the container - fixes wagtail#107
- use variable for the max-width of the version picker (300px on bootstrap variables)
- add layout scss to fix some global style issues (already on Wagtail core)
- add .sidebar-container so that we can have a max width on navbar - fixes wagtail#99
- use .sidebar-container to allow for border-right on larger devices to match designs - fixes wagtail#59
- resolve styling issues with sidebar container & overflow scroll - fixes wagtail#190
- avoid using coded styles when bootstrap utility classes are suitable in the sidebar & search box
- add high contrast focus outline to focusable (tabbable) elements - fixes wagtail#23
@lb- lb- closed this as completed in #191 Aug 18, 2022
lb- pushed a commit that referenced this issue Aug 18, 2022
@lb-
multiple minor styling fixes
5301999 
- fix gap after content within admonitions, avoid styling every last element inside, only the container - fixes #107
- use variable for the max-width of the version picker (300px on bootstrap variables)
- add layout scss to fix some global style issues (already on Wagtail core)
- add .sidebar-container so that we can have a max width on navbar - fixes #99
- use .sidebar-container to allow for border-right on larger devices to match designs - fixes #59
- resolve styling issues with sidebar container & overflow scroll - fixes #190
- avoid using coded styles when bootstrap utility classes are suitable in the sidebar & search box
- add high contrast focus outline to focusable (tabbable) elements - fixes #23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix multiple minor styling issues lb-/sphinx_wagtail_theme
4 participants
@lb- @Stormheg @tbrlpld @PaarthAgarwal