Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #914 neither desiredtz nor rmc.desiredtz processed correctly for ad hoc csv files #915

Merged
merged 5 commits into from
Sep 27, 2023

Conversation

l-k-
Copy link
Collaborator

@l-k- l-k- commented Sep 26, 2023

This fixes 914

Making sure both desiredtz/configtz and rmc.desiredtz/rmc.configtz are passed to read.myacc.csv() correctly.

Checklist before merging:

  • Existing tests still work (check by running the test suite, e.g. from RStudio).
  • Added tests (if you added functionality) or fixed existing test (if you fixed a bug).
  • Updated or expanded the documentation.
  • Updated release notes in inst/NEWS.Rd with a user-readable summary. Please, include references to relevant issues or PR discussions.
  • Added your name to the contributors lists in the DESCRIPTION and CITATION.cff files.

@l-k- l-k- changed the title Issue 914 desiredtz Issue #914 desiredtz Sep 26, 2023
@l-k- l-k- changed the title Issue #914 desiredtz Issue #914 neither desiredtz not rmc.desiredtz processed correctly for ad hoc csv files Sep 26, 2023
@l-k- l-k- changed the title Issue #914 neither desiredtz not rmc.desiredtz processed correctly for ad hoc csv files Issue #914 neither desiredtz nor rmc.desiredtz processed correctly for ad hoc csv files Sep 26, 2023
Copy link
Member

@vincentvanhees vincentvanhees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I have now added one line to the NEWS.md to describe this update.

@codecov-commenter
Copy link

Codecov Report

Merging #915 (5bd955a) into master (45a1569) will decrease coverage by 0.03%.
The diff coverage is 12.50%.

❗ Current head 5bd955a differs from pull request most recent head 71a266a. Consider uploading reports for the commit 71a266a to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##           master     #915      +/-   ##
==========================================
- Coverage   78.41%   78.39%   -0.03%     
==========================================
  Files          92       92              
  Lines       12338    12342       +4     
==========================================
  Hits         9675     9675              
- Misses       2663     2667       +4     
Files Coverage Δ
R/read.myacc.csv.R 75.00% <50.00%> (-0.36%) ⬇️
R/g.readaccfile.R 42.23% <0.00%> (ø)
R/g.inspectfile.R 56.96% <0.00%> (-0.74%) ⬇️

@vincentvanhees vincentvanhees merged commit 4e4ebd4 into master Sep 27, 2023
8 checks passed
@vincentvanhees vincentvanhees deleted the issue-914-desiredtz branch September 27, 2023 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues with desiredtz
3 participants