You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently desiredtz and configtz aren't passed in the call to read.myacc.csv() from from g.inspectfile().
In addition, readaccfile(), when gathering parameters for a call to read.myacc.csv(), looks for rmc.desiredtz and rmc.configtz in params_general[ ], not in params_rawdata[ ] where they actually are. So rmc.desiredtz and rmc.configtz values aren't passed to read.myacc.csv().
Because of this, neither method of specifying desiredtz/configtz for an ad hoc csv file actually works.
To Reproduce
Specify desiredtz in a call to GGIR for an ad hoc csv file, something like this:
You will get an error: "Timezone not specified, please provide at least desiredtz and consider specifying configtz."
Reproducing (2) is trickier, you need to step through the code and see that rmc.desiredtz isn't passed into read.myacc.csv(), and so the timezone isn't applied correctly.
In GGIR 2.10-1 a similar issue was causing an error (and that's what people on the message board are complaining about, since they can use neither desiredtz nor rmc.desiredtz), but that was fixed by code simplification in 738ba40 and 2faa203, and now it's a silent issue rather than a crash.
Before submitting
Have you tried this on the latest master branch from GitHub?
The text was updated successfully, but these errors were encountered:
I'm sending a PR in a bit.
Describe the bug
This relates to an issue raised in the google group: https://groups.google.com/g/RpackageGGIR/c/tzcAWzxwX1k
Currently desiredtz and configtz aren't passed in the call to read.myacc.csv() from from g.inspectfile().
In addition, readaccfile(), when gathering parameters for a call to read.myacc.csv(), looks for rmc.desiredtz and rmc.configtz in params_general[ ], not in params_rawdata[ ] where they actually are. So rmc.desiredtz and rmc.configtz values aren't passed to read.myacc.csv().
Because of this, neither method of specifying desiredtz/configtz for an ad hoc csv file actually works.
To Reproduce
GGIR(datadir="/Users/lenka/data", outputdir="/Users/lenka/result", desiredtz="Europe/London", rmc.firstrow.acc=2, rmc.sf=80, rmc.col.time=1, rmc.unit.time = "UNIXsec", rmc.col.acc = 2:4)
You will get an error: "Timezone not specified, please provide at least desiredtz and consider specifying configtz."
In GGIR 2.10-1 a similar issue was causing an error (and that's what people on the message board are complaining about, since they can use neither desiredtz nor rmc.desiredtz), but that was fixed by code simplification in 738ba40 and 2faa203, and now it's a silent issue rather than a crash.
Before submitting
master
branch from GitHub?The text was updated successfully, but these errors were encountered: