Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with desiredtz #914

Closed
1 task done
l-k- opened this issue Sep 26, 2023 · 0 comments · Fixed by #915
Closed
1 task done

Issues with desiredtz #914

l-k- opened this issue Sep 26, 2023 · 0 comments · Fixed by #915

Comments

@l-k-
Copy link
Collaborator

l-k- commented Sep 26, 2023

I'm sending a PR in a bit.

Describe the bug

This relates to an issue raised in the google group: https://groups.google.com/g/RpackageGGIR/c/tzcAWzxwX1k

  1. Currently desiredtz and configtz aren't passed in the call to read.myacc.csv() from from g.inspectfile().

  2. In addition, readaccfile(), when gathering parameters for a call to read.myacc.csv(), looks for rmc.desiredtz and rmc.configtz in params_general[ ], not in params_rawdata[ ] where they actually are. So rmc.desiredtz and rmc.configtz values aren't passed to read.myacc.csv().

Because of this, neither method of specifying desiredtz/configtz for an ad hoc csv file actually works.

To Reproduce

  1. Specify desiredtz in a call to GGIR for an ad hoc csv file, something like this:

GGIR(datadir="/Users/lenka/data", outputdir="/Users/lenka/result", desiredtz="Europe/London", rmc.firstrow.acc=2, rmc.sf=80, rmc.col.time=1, rmc.unit.time = "UNIXsec", rmc.col.acc = 2:4)

You will get an error: "Timezone not specified, please provide at least desiredtz and consider specifying configtz."

  1. Reproducing (2) is trickier, you need to step through the code and see that rmc.desiredtz isn't passed into read.myacc.csv(), and so the timezone isn't applied correctly.
    In GGIR 2.10-1 a similar issue was causing an error (and that's what people on the message board are complaining about, since they can use neither desiredtz nor rmc.desiredtz), but that was fixed by code simplification in 738ba40 and 2faa203, and now it's a silent issue rather than a crash.

Before submitting

  • Have you tried this on the latest master branch from GitHub?
@l-k- l-k- self-assigned this Sep 26, 2023
vincentvanhees added a commit that referenced this issue Sep 27, 2023
Issue #914 neither desiredtz nor rmc.desiredtz processed correctly for ad hoc csv files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants