-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finalize the context URL for the spec to address #206. #258
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
a2972fe
Fix all VC JSON-LD Context URLs. See #206.
msporny b4d88ff
Add note about static VC JSON-LD Context and vocab. See #206.
msporny a635f00
Add section on Contexts. See #206.
msporny 27269e0
Refer to Extensibility section from Contexts section.
msporny 2399114
Add note about example context. See #245.
msporny 7d66396
Fix namespace documents as requested by @gkellogg.
msporny File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,7 +10,7 @@ | |
specStatus: "base", | ||
shortName: "vc-vocab", | ||
publishDate: "2018-07-25", | ||
thisVersion: "http://w3id.org/credentials", | ||
thisVersion: "http://w3.org/2018/credentials", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should this be https? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, it should. |
||
doJsonLd: true, | ||
//edDraftURI: "https://w3c.github.io/vc-vocab/", | ||
// lcEnd: "3000-01-01", | ||
|
@@ -72,7 +72,7 @@ | |
.bold {font-weight: bold;} | ||
</style> | ||
</head> | ||
<body resource="https://w3id.org/credentials#" typeof="owl:Ontology" prefix="cred: https://w3id.org/credentials#"> | ||
<body resource="https://w3.org/2018/credentials#" typeof="owl:Ontology" prefix="cred: https://w3.org/2018/credentials#"> | ||
<section id="abstract"> | ||
<p>This document describes the | ||
<span property="dc:title">Verifiable Claims Vocabulary</span> | ||
|
@@ -89,7 +89,7 @@ | |
<dt>Published:</dt><dd><time property="dc:date">2018-07-25</time></dd> | ||
<dt>Imports:</dt> | ||
<dd><a href="http://purl.org/dc/terms/" property="owl:imports">http://purl.org/dc/terms/</a></dd> | ||
<dd><a href="https://w3id.org/security" property="owl:imports">https://w3id.org/security</a></dd> | ||
<dd><a href="https://w3.org/2018/security" property="owl:imports">https://w3.org/2018/security</a></dd> | ||
<dt>Version Info:</dt> | ||
<dd><a href="" property="owl:versionInfo"></a></dd> | ||
<dt>See Also:</dt> | ||
|
@@ -107,11 +107,11 @@ <h2>Introduction</h2> | |
<p>This specification makes use of the following namespaces:</p> | ||
<dl class="terms"> | ||
<dt><code>cred</code>:</dt> | ||
<dd><code>https://w3id.org/credentials#</code></dd> | ||
<dd><code>https://w3.org/2018/credentials#</code></dd> | ||
<dt><code>dc</code>:</dt> | ||
<dd><code>http://purl.org/dc/terms/</code></dd> | ||
<dt><code>sec</code>:</dt> | ||
<dd><code>https://w3id.org/security#</code></dd> | ||
<dd><code>https://w3.org/2018/security#</code></dd> | ||
<dt><code>xsd</code>:</dt> | ||
<dd><code>http://www.w3.org/2001/XMLSchema#</code></dd> | ||
</dl> | ||
|
@@ -291,7 +291,7 @@ <h2>Term Definitions</h2> | |
</dd> | ||
<dt>cred</dt> | ||
<dd> | ||
https://w3id.org/credentials# | ||
https://w3.org/2018/credentials# | ||
</dd> | ||
<dt>credentialStatus</dt> | ||
<dd> | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The meaning of a verifiable credential could change if its context changes. I'm concerned that requiring only a URI (which by its nature is a mutable reference), we are not requiring any sort of guarantee that the context pointed to by the URI won't change over time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is also my concern, especially since it is proposed to move Issuer Terms of Use to the @context from the VC itself. The advantage of this move is that the holder of a ZPK credentials cannot hide the terms of use, which he could if it were an assertion in the VC. The disadvantage is that the verifier has to rely on the contents of URLs being immutable. Can we propose some crypto to guarantee that if the contents change, the verifier can detect this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can't solve this issue in this PR. As @gkellogg mentioned, it's a separate broader Web/JSON-LD ecosystem issue. There are options, but we are unlikely to settle on a standard before the VCWG is done. I know that @dmitrizagidulin is going to document all the options over in the JSON-LD WG's issue repository.