Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalize the context URL for the spec to address #206. #258

Merged
merged 6 commits into from
Nov 1, 2018

Conversation

msporny
Copy link
Member

@msporny msporny commented Oct 28, 2018

@gkellogg
Copy link
Member

Do we need to make corresponding changes to the namespace documents, which include the context file?

@msporny
Copy link
Member Author

msporny commented Oct 28, 2018

Do we need to make corresponding changes to the namespace documents, which include the context file?

Yes, we do. :) -- this PR needs to be updated to do that. I'll do that on my next edit cycle.

@msporny
Copy link
Member Author

msporny commented Oct 30, 2018

Hold on review by @brentzundel until Nov 1st.

<dl>
<dt><dfn>@context</dfn></dt>
<dd>
The value of this property MUST be one or more URIs where first URI is the
Copy link
Member

@brentzundel brentzundel Oct 31, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The meaning of a verifiable credential could change if its context changes. I'm concerned that requiring only a URI (which by its nature is a mutable reference), we are not requiring any sort of guarantee that the context pointed to by the URI won't change over time.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also my concern, especially since it is proposed to move Issuer Terms of Use to the @context from the VC itself. The advantage of this move is that the holder of a ZPK credentials cannot hide the terms of use, which he could if it were an assertion in the VC. The disadvantage is that the verifier has to rely on the contents of URLs being immutable. Can we propose some crypto to guarantee that if the contents change, the verifier can detect this.

Copy link
Member Author

@msporny msporny Nov 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't solve this issue in this PR. As @gkellogg mentioned, it's a separate broader Web/JSON-LD ecosystem issue. There are options, but we are unlikely to settle on a standard before the VCWG is done. I know that @dmitrizagidulin is going to document all the options over in the JSON-LD WG's issue repository.

@gkellogg
Copy link
Member

gkellogg commented Nov 1, 2018

This is an issue the JSON-LD WG expects to tackle, although is not solved just yet. See w3c/json-ld-syntax#9 and the TPAC F2F Minutes.

@msporny
Copy link
Member Author

msporny commented Nov 1, 2018

Review received by @brentzundel, only issue raised is one we can't deal with in this PR (it's a broader ecosystem issue). Made changes requested by @gkellogg. Merging.

@msporny msporny merged commit b3a95a7 into gh-pages Nov 1, 2018
@@ -10,7 +10,7 @@
specStatus: "base",
shortName: "vc-vocab",
publishDate: "2018-07-25",
thisVersion: "http://w3id.org/credentials",
thisVersion: "http://w3.org/2018/credentials",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be https?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it should.

@@ -10,7 +10,7 @@
specStatus: "base",
shortName: "vc-vocab",
publishDate: "<%=ont["dc:date"]%>",
thisVersion: "http://w3id.org/credentials",
thisVersion: "http://w3.org/2018/credentials",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it should.

@davidlehn
Copy link
Contributor

How relevant is the namespace advice from https://www.w3.org/2005/07/13-nsuri? That would imply URIs should be http://www.w3.org/2018/ssss vs https://w3.org/2018/ssss.

@msporny
Copy link
Member Author

msporny commented Nov 2, 2018

How relevant is the namespace advice from https://www.w3.org/2005/07/13-nsuri? That would imply URIs should be http://www.w3.org/2018/ssss vs https://w3.org/2018/ssss.

I'm hoping not very relevant. :P - we should make an argument that this is something developers might type out and we'd rather not have them do the whole outdated "www" thing.

@msporny msporny deleted the msporny-context-url branch December 12, 2018 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants