-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed the term mediaType
to encodingFormat
#1440
Conversation
@msporny I am not sure how the SHA value of the context lands in the spec (in §B.1). Is it automatic, or should I generate it before merge? |
It's not automatic, and we really, really, should add some code (to respec?) to make it automatic. Doing that has been on my to-do list for over a year. I was thinking of adding it to the respec-vc tool. /cc @davidlehn :) But for now, feel free to re-generate the hash by hand (or just leave it alone until we automate the process). |
I prefer not to do it, because I am not 100% sure I would produce the right value, and that would be worse. In a way, it does not matter so much; this is a new CR draft; what is important to get these values right by PR (there are also hashes for the vocabulary files). |
`mediaType` that indicates the expected media type for the indicated | ||
`resource`. If a `mediaType` is included, its value | ||
`encodingFormat` that indicates the expected media type for the indicated | ||
`resource`. If a `encodingFormat` is included, its value |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
`resource`. If a `encodingFormat` is included, its value | |
`resource`. If an `encodingFormat` is included, its value |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I oppose changing from mediaType, which is a well-known term, to encodingFormat, which we'd be making up.
The issue was discussed in a meeting on 2024-02-21
View the transcript3.2. Changed the term
|
Per https://www.w3.org/2017/vc/WG/Meetings/Minutes/2024-02-21-vcwg#section3-2 closing without merge. |
- Switch `encodingFormat` term back to `mediaType`. - w3c/vc-data-model#1408 - w3c/vc-data-model#1440 - Add `EnvelopedVerifiablePresentation`. - Add type for `statusReference` and `statusSize`. - Fix whitespace.
- Switch `encodingFormat` term back to `mediaType`. - w3c/vc-data-model#1408 - w3c/vc-data-model#1440 - Add `EnvelopedVerifiablePresentation`. - Add type for `statusReference` and `statusSize`. - Fix whitespace.
- Switch `encodingFormat` term back to `mediaType`. - w3c/vc-data-model#1408 - w3c/vc-data-model#1440 - Add `EnvelopedVerifiablePresentation`. - Add type for `statusReference` and `statusSize`. - Fix whitespace.
As agreed on the WG call to handle issue #1408.
See also related comment in #1438 (review).
Preview | Diff