-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clarify inputBytes, inputDocument, inputMediaType #1438
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A very practical issue aiming to avoid future merge conflicts...
Following the WG agreement, I have created a PR (#1440) changing the property mediaType
to encodingFormat
. I was wondering whether it wouldn't be better, for the sake of consistency, to use the term inputEncodingFormat
instead of inputMediaType
in this algorithm. It may be wiser if we agreed on this issue in this PR and, possibly, the term was changed here (and my PR concentrates exclusively on the property).
Note that the term mediaType
also appears in the body of the algorithm. That should either be changed or kept unchanged, in sync with the change of the argument name.
Personally, I am in favour of changing the algorithm argument name, but I won't lie down the road if the agreement is to leave it as is.
Consistency is generally better than not. That said, I don't like the change to I also note (too late for that decision, but perhaps it might be reconsidered) https://www.w3.org/ns/iana/media-types/ which seems like it should be taken into account for W3 purposes. |
I have to agree with you on this. As I said, I can live with inconsistency; we just to agree that we all accept it.
This is a very strange namespace (never saw this before). It seems to assign, for each specific media type, a class. If we used this, Example 28 would look like: "image": {
"id": "https:....",
"digestSRI" : "sha384-......",
"type" : "https://www.w3.org/ns/iana/media-types/image/svg+xml#Resource" this can work, but I am afraid it would be a bit unnatural to use... |
s/" (And, of course, the document at the latter link includes mention of |
Yep, sorry. I will edit the comment just to make it o.k.
|
@iherman this one ready too? |
@decentralgabe yes. The issue of |
editorial approval, open >1 week, changes addressed. merging! |
fixes #1402
Preview | Diff