-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update BitstringStatusList context to align with latest spec. #109
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, this is an improvement -- we'll probably need additional tweaking after more discussion around things like ttl
, etc.
contexts/v1.jsonld
Outdated
"https://www.w3.org/ns/credentials/status-list#encodedList", | ||
"ttl": "https://www.w3.org/ns/credentials/status-list#ttl", | ||
"reference": "https://www.w3.org/ns/credentials/status-list#reference", | ||
"size": "https://www.w3.org/ns/credentials/status-list#size", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is actually the size of the status (not the size of the list). This is misnamed/mismodeled and should probably be statusSize
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is being tracked in issue #113 (but we might as well make the change here).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 35860ac.
contexts/v1.jsonld
Outdated
"encodedList": | ||
"https://www.w3.org/ns/credentials/status-list#encodedList", | ||
"ttl": "https://www.w3.org/ns/credentials/status-list#ttl", | ||
"reference": "https://www.w3.org/ns/credentials/status-list#reference", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a reference for the list, but for the status (or statuses). The main use case envisaged at the moment is for a dictionary of statuses / status messages. This should be renamed to statusReference
on that basis.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is being tracked in issue #114 (but we might as well make the change here).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 35860ac.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
35860ac
to
4205f4e
Compare
Normative, multiple reviews, changes requested and made, no objections, merging. |
This PR is an attempt at addressing issue #70, which updates the context to align with the latest specification.
It preserves the old 2021 status list since that's where the w3id.org redirect goes currently, and we believe some organizations have deployed 2021 status list into potentially production environments. We need to preserve that file for now in order to not break implementations that aren't (mistakenly) caching their JSON-LD Contexts until we can move it back to the CCG or host it elsewhere (or decide to continue hosting it here).
Preview | Diff