Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename reference to statusReference #114

Closed
dlongley opened this issue Dec 29, 2023 · 2 comments
Closed

Rename reference to statusReference #114

dlongley opened this issue Dec 29, 2023 · 2 comments
Assignees
@msporny
Labels
before-CR This issue needs to be resolved before the Candidate Recommendation phase. pr exists

Comments

@dlongley
Copy link
Contributor

reference is not a reference for the list, but for the status (or statuses). The main use case envisaged at the moment is for a dictionary of statuses / status messages. This should be renamed to statusReference on that basis. If there's only one use case that really makes sense, and it's a status dictionary, then we could rename it statusDictionary and provide a fuller example.

Originally posted by @dlongley in #109 (comment)
@msporny msporny added before-CR This issue needs to be resolved before the Candidate Recommendation phase. ready for pr labels Dec 29, 2023
@msporny msporny self-assigned this Dec 29, 2023
@msporny msporny mentioned this issue Dec 30, 2023
Merged
@msporny
Copy link
Member

msporny commented Jan 2, 2024

The fix has been applied in PR #109. This issue will be closed once PR #109 has been merged.

@msporny
Copy link
Member

msporny commented Jan 13, 2024

PR #109 has been merged, closing.

@msporny msporny closed this as completed Jan 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@msporny msporny

Labels
before-CR This issue needs to be resolved before the Candidate Recommendation phase. pr exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@msporny @dlongley