Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent terminology #405

Open
chrisn opened this issue Jan 8, 2024 · 6 comments
Open

Consistent terminology #405

chrisn opened this issue Jan 8, 2024 · 6 comments
Assignees
Milestone

Comments

@chrisn
Copy link
Member

chrisn commented Jan 8, 2024

Originally raised by @fintelia as part of #346:

A bunch of sections use different terminology, likely because they were written at different times by different people:

Section 4.2: Talks about a "source image" getting transformed into a "reference image", with the former explicitly left out of scope of the spec and the later consisting of dimensionless RGB or RGBA channels with $2^{sampledepth}$ bits.

cHRM chunk: Talks about display primaries "used" in "the image", without indicating whether that's the source image, reference image, or some other image.

sRGB chunk: Now the samples "conform" to a colour space and have a "rendering intent"

cICP and mDCv chunks: TV terminology as mentioned

Section 12.1 This section leans heavily into talking about samples being "light intensities" in an abstract 0-1 range. The concept of > "original scene intensity" is mentioned but glossed over.

transfer function definition: "image luminance", "image samples"

@ProgramMax
Copy link
Collaborator

Assigning to CS as discussed last meeting.

@ProgramMax
Copy link
Collaborator

Also adding Simon.

@chrisn
Copy link
Member Author

chrisn commented Apr 19, 2024

Another one I noticed: in Table 2, for mDCV there's "eventual display" but elsewhere in the spec the same concept is "display device".

chrisn added a commit that referenced this issue Apr 19, 2024
chrisn added a commit that referenced this issue Apr 19, 2024
@chrisn chrisn assigned chrisn, ProgramMax and svgeesus and unassigned digitaltvguy Apr 19, 2024
@chrisn
Copy link
Member Author

chrisn commented Apr 19, 2024

I created a draft PR #449 to fix some of these, but it's not clear to me how to address them all. @fintelia, do you have suggestions on changes to be made?

chrisn added a commit that referenced this issue Apr 19, 2024
chrisn added a commit that referenced this issue Apr 19, 2024
@fintelia
Copy link

fintelia commented Apr 22, 2024

I don't think there's any quick fixes that will make everything consistent and to be honest I'm not sure it is worth trying to align everything. If you wanted to, it would be a matter of picking one set of terminology and then rewriting each section to use that same terminology. So the gAMA chunk would say that it is a transfer function, sRGB and cICP would use the same terminology, etc.

@svgeesus
Copy link
Contributor

I agree this is actually quite a lot of work.

It might be possible to do this incrementally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

6 participants