Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of TV specific terminology #346

Closed
chrisn opened this issue Aug 15, 2023 · 8 comments
Closed

Use of TV specific terminology #346

chrisn opened this issue Aug 15, 2023 · 8 comments

Comments

@chrisn
Copy link
Member

chrisn commented Aug 15, 2023

Reading through the current spec draft, I notice that there are a few terms used that are specific to TV production, and should be reviewed, as PNG is a general purpose graphics format and TV production is a small subset of its use cases. For example: "SDR" (as there are many different SDR formats, as @simontWork has mentioned in #343), and the terms "shading" and "single-master".

@fintelia
Copy link

It isn't just TV terminology. A bunch of sections use different terminology, likely because they were written at different times by different people:

Section 4.2: Talks about a "source image" getting transformed into a "reference image", with the former explicitly left out of scope of the spec and the later consisting of dimensionless RGB or RGBA channels with $2^{sampledepth}$ bits.

cHRM chunk: Talks about display primaries "used" in "the image", without indicating whether that's the source image, reference image, or some other image.

sRGB chunk: Now the samples "conform" to a colour space and have a "rendering intent"

cICP and mDCv chunks: TV terminology as mentioned

Section 12.1 This section leans heavily into talking about samples being "light intensities" in an abstract 0-1 range. The concept of "original scene intensity" is mentioned but glossed over.

transfer function definition: "image luminance", "image samples"

@simontWork
Copy link
Contributor

I think also the definition of luminance (and luma) could be tightened too.
Luminance is a photometric measurement of intensity per area, brightness is the perception of luminance.

digitaltvguy added a commit to digitaltvguy/PNG-spec that referenced this issue Aug 21, 2023
@ProgramMax ProgramMax added this to the 3rd edition milestone Aug 21, 2023
svgeesus added a commit that referenced this issue Aug 24, 2023
…339)

* Added improved description to cLLi chunk and references

Added improved description to cLLi chunk and references to CTA 861-3 Annex P and SMPTE ST 2067-21 Section 7.5

* additional descriptive info on cLLI

added more language around how cLLi optimizes tone mapping

* added SDR and HDR references to BT.709 and BT.2100 respectively (issue #346)

Tied to issue #346

---------

Co-authored-by: Chris Lilley <[email protected]>
@simontWork
Copy link
Contributor

Looking at the mDCv chunk, I think that the phrasing is still incorrect.

SDR covers a large range of file formats, not just BT.709. sRGB, AdobeRGB, ProPhoto all have fixed viewing environments and BT.709 has a reference viewing environment published in ITU-R BT.2035.

What does the end user do with an sRGB image that has an mCDv maximum luminance of 200? This just says that the file does not comply with the specification and needs some form of adaptation. There is however no specification of what that adaptation is. I don't think we can use normative text for SDR formats, "may" is probably the strongest that can be used.

@svgeesus
Copy link
Contributor

svgeesus commented Sep 7, 2023

It isn't just TV terminology. A bunch of sections use different terminology, likely because they were written at different times by different people:

Sometimes, yes. Other times because they are talking about different things, or at different levels of abstraction.

Section 4.2: Talks about a "source image" getting transformed into a "reference image", with the former explicitly left out of scope of the spec and the later consisting of dimensionless RGB or RGBA channels with $2^{sampledepth}$ bits.

Right. Those concepts were introduced in second edition, largely to help pin down what lossless means. For example I have a GIF image, whose palette has a dark brown in the first slot, a light green in the second slot and so on. I convert it to PNG. Can I rely on the green still being the second palette entry? No (and palettes are not part of the reference image). Is PNG lossless? Yes, it losslessly encodes the reference image.

cHRM chunk: Talks about display primaries "used" in "the image", without indicating whether that's the source image, reference image, or some other image.

The spec already asserts that these should be the same:

It is not recommended that datastream format converters attempt to convert supplied images to a different RGB colour space. The data should be stored in the PNG datastream without conversion, and the source primary chromaticities should be recorded if they are known. Colour space transformation at datastream conversion time is a bad idea because of gamut mismatches and rounding errors.

@svgeesus
Copy link
Contributor

svgeesus commented Sep 7, 2023

What does the end user do with an sRGB image that has an mCDv maximum luminance of 200? This just says that the file does not comply with the specification and needs some form of adaptation.

Does it really though? But yes, there is no definition for any adaptation that might be needed for a display-referred, relative luminance image displayed in non-reference viewing conditions.

I don't think we can use normative text for SDR formats, "may" is probably the strongest that can be used.

I agree we should use "may" here.

@svgeesus
Copy link
Contributor

svgeesus commented Sep 7, 2023

Luminance is a photometric measurement of intensity per area, brightness is the perception of luminance.

Right (for the first part. The second is misleading unless we mention cube roots). Currently the definition in the spec is a bit weak:

luminance
perceived brightness of a colour
Note

Luminance and chromaticity together fully define a perceived colour. A formal definition of luminance is found at [COLORIMETRY].

Of course, if we define luminance correctly this then adds the problem that we need to define the terms photometric, luminous intensity, and photopic observer.

In terms of the average readership (who will not have purchased CIE 15, so isn't helped by our current reference) perhaps we could point to something like

https://colorusage.arc.nasa.gov/lum_and_chrom.php

and give a better, but still informal, definition? Something like

Luminance:
an objective measurement of the emitted light intensity, taking into account the sensitivity of the human eye to different wavelengths. See Luminance and Chromaticity or, for a formal definition, [[Colorimetry]].

svgeesus added a commit that referenced this issue Sep 19, 2023
* Added improved description to cLLi chunk and references

Added improved description to cLLi chunk and references to CTA 861-3 Annex P and SMPTE ST 2067-21 Section 7.5

* additional descriptive info on cLLI

added more language around how cLLi optimizes tone mapping

* added SDR and HDR references to BT.709 and BT.2100 respectively (issue #346)

Tied to issue #346

* updated mDCv chunk definition

The most important addition modifies "should" to "may" but also provides improved definitions for the mDCv use-case.

* typo

* spaces where they were missing

* handle conflicts caused by not rebasing

---------

Co-authored-by: Chris Lilley <[email protected]>
@Myndex
Copy link
Member

Myndex commented Oct 27, 2023

I think the simplest definition:

  • Luminance $L$ — a physical measure of visible light intensity.

Works for most purposes. If we add in the weighting for spectral sensitivity, then we need to futher clarify that lightness, darkness, and brightness are not part of that weighting.

A more complete, mini-definition:

  • Luminance $L$ — a physical measure of visible light intensity.

    • Luminance is measured from a surface, expressed as candela per square meter (cd·m²).
    • Luminance is weighted per the spectral sensitivity of human vision.
    • Luminance is mathematically linear, as is physical light.
      • Therefore, Luminance is not proportional to the human visual perception of lightness, darkness, or brightness.
  • Relative luminance $Y$ is proportional to physical values of luminance.

    • $Y$ is normalized to a range, such a 0 (black) to 100 (white).
    • The symbol $Y$ relates to CIE 1931 $XYZ$ and should not be confused with $Y^\prime$
  • Luma $Y^\prime$ (Y prime) is a gamma encoded signal, used in some broadcast video systems.


See also: https://cie.co.at/eilvterm/17-21-050

@chrisn chrisn mentioned this issue Nov 9, 2023
This was referenced Jan 8, 2024
@chrisn
Copy link
Member Author

chrisn commented Jan 8, 2024

I have copied the issues mentioned by @fintelia to #405 and the luminance discussion to #406, as the other points discussed here have been resolved in the spec, and we'd like to close this issue.

@chrisn chrisn closed this as completed Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants