-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use of TV specific terminology #346
Comments
It isn't just TV terminology. A bunch of sections use different terminology, likely because they were written at different times by different people: Section 4.2: Talks about a "source image" getting transformed into a "reference image", with the former explicitly left out of scope of the spec and the later consisting of dimensionless RGB or RGBA channels with cHRM chunk: Talks about display primaries "used" in "the image", without indicating whether that's the source image, reference image, or some other image. sRGB chunk: Now the samples "conform" to a colour space and have a "rendering intent" cICP and mDCv chunks: TV terminology as mentioned Section 12.1 This section leans heavily into talking about samples being "light intensities" in an abstract 0-1 range. The concept of "original scene intensity" is mentioned but glossed over. transfer function definition: "image luminance", "image samples" |
I think also the definition of luminance (and luma) could be tightened too. |
…339) * Added improved description to cLLi chunk and references Added improved description to cLLi chunk and references to CTA 861-3 Annex P and SMPTE ST 2067-21 Section 7.5 * additional descriptive info on cLLI added more language around how cLLi optimizes tone mapping * added SDR and HDR references to BT.709 and BT.2100 respectively (issue #346) Tied to issue #346 --------- Co-authored-by: Chris Lilley <[email protected]>
Looking at the mDCv chunk, I think that the phrasing is still incorrect. SDR covers a large range of file formats, not just BT.709. sRGB, AdobeRGB, ProPhoto all have fixed viewing environments and BT.709 has a reference viewing environment published in ITU-R BT.2035. What does the end user do with an sRGB image that has an mCDv maximum luminance of 200? This just says that the file does not comply with the specification and needs some form of adaptation. There is however no specification of what that adaptation is. I don't think we can use normative text for SDR formats, "may" is probably the strongest that can be used. |
Sometimes, yes. Other times because they are talking about different things, or at different levels of abstraction.
Right. Those concepts were introduced in second edition, largely to help pin down what lossless means. For example I have a GIF image, whose palette has a dark brown in the first slot, a light green in the second slot and so on. I convert it to PNG. Can I rely on the green still being the second palette entry? No (and palettes are not part of the reference image). Is PNG lossless? Yes, it losslessly encodes the reference image.
The spec already asserts that these should be the same:
|
Does it really though? But yes, there is no definition for any adaptation that might be needed for a display-referred, relative luminance image displayed in non-reference viewing conditions.
I agree we should use "may" here. |
Right (for the first part. The second is misleading unless we mention cube roots). Currently the definition in the spec is a bit weak:
Of course, if we define luminance correctly this then adds the problem that we need to define the terms photometric, luminous intensity, and photopic observer. In terms of the average readership (who will not have purchased CIE 15, so isn't helped by our current reference) perhaps we could point to something like https://colorusage.arc.nasa.gov/lum_and_chrom.php and give a better, but still informal, definition? Something like Luminance: |
* Added improved description to cLLi chunk and references Added improved description to cLLi chunk and references to CTA 861-3 Annex P and SMPTE ST 2067-21 Section 7.5 * additional descriptive info on cLLI added more language around how cLLi optimizes tone mapping * added SDR and HDR references to BT.709 and BT.2100 respectively (issue #346) Tied to issue #346 * updated mDCv chunk definition The most important addition modifies "should" to "may" but also provides improved definitions for the mDCv use-case. * typo * spaces where they were missing * handle conflicts caused by not rebasing --------- Co-authored-by: Chris Lilley <[email protected]>
I think the simplest definition:
Works for most purposes. If we add in the weighting for spectral sensitivity, then we need to futher clarify that lightness, darkness, and brightness are not part of that weighting. A more complete, mini-definition:
See also: https://cie.co.at/eilvterm/17-21-050 |
Reading through the current spec draft, I notice that there are a few terms used that are specific to TV production, and should be reviewed, as PNG is a general purpose graphics format and TV production is a small subset of its use cases. For example: "SDR" (as there are many different SDR formats, as @simontWork has mentioned in #343), and the terms "shading" and "single-master".
The text was updated successfully, but these errors were encountered: