Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve pipeline model text description clarity #310

Merged
merged 1 commit into from
May 18, 2022
Merged

Improve pipeline model text description clarity #310

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 13 additions & 8 deletions pipeline_model_description.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ <h2 id='pipelinedesc'>Non-technical description of the Process Flowchart image</




<h3 id='sourcebuffer1'>Flowing down from SourceBuffer 1</h3>


Expand All @@ -46,29 +45,35 @@ <h3 id='sourcebuffer1'>Flowing down from SourceBuffer 1</h3>
then follows to an indicator of an open switch, which then continues to an
indicator (green circle with an X) labeled Audio Device.</p>

<p>The third Track Buffer also flows to a green box labeled Video Decoder,
<p>The third Track Buffer also flows to a green box labeled Audio Decoder,
which also flows to a switch, this time however indicated closed, which then
also continues to the same indicator (green circle with an X) labeled Audio
Device as the second Track Buffer.</p>




<h3 id='sourcebuffer2'>Flowing down from SourceBuffer 2</h3>


<p>Flowing down from SourceBuffer 2 is a mauve triangle with an arrow flowing
to a red box labeled Video Decoder, which then flows to the same Video Tag
Display Region previously mentioned in SourceBuffer 1.</p>
to a process indication labeled Track Buffer.<p>

<p>This Track Buffer then flows to a red box labeled Video Decoder, which
then flows to the same Video Tag Display Region previously mentioned in
SourceBuffer 1.</p>



<h3 id='sourcebuffer3'>Flowing down from SourceBuffer 3</h3>


<p>Flowing down from SourceBuffer 3 is a rose triangle with an arrow flowing to
a green box labeled Audio Decoder, which then flows through a closed switch,
which then also continues to the same indicator (green circle with an X)
labeled Audio Device previously mentioned in SourceBuffer 1</p>
a process indication labeled Track Buffer.<p>

<p>This Track Buffer then flows to a green box labeled Audio Decoder, which
then flows through a closed switch, which then also continues to the same
indicator (green circle with an X) labeled Audio Device previously mentioned in
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could rephrase this to describe the purpose of "indicator (green circle with an X)". In a flow chart (I just looked this up...) the symbol is a "summing junction" which suggests that any enabled audio tracks are summed, i.e., mixed to form the output audio. This corresponds with definition of AudioTrack.

Unless you prefer to do it, I could raise a PR with suggested text along those lines.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. PR sounds good to me if you have time. I've filed an issue to ensure this gets done one way or the other :)
#314

SourceBuffer 1</p>


<p style='text-align: right;'>With thanks to <a href='https://lists.w3.org/Archives/Public/public-apa/2016Jan/0014.html'>J. Foliot, Deque Systems</a></p>
Expand Down