Improve pipeline model text description clarity #310
Conversation
Fixes a typo (one of the flows incorrectly was described as going to a Video Decoder, not an Audio Decoder), and fixes a couple omissions of mentions of track buffer process indications between SourceBuffer 2 Video Decoder, and between SourceBuffer 3 and Audio Decoder.
Well, there seems to be a bug somewhere that crashes the update of the |
Thank you. I'll await @mwatson2 review of this and eventually |
|
@mwatson2 - please review this when you can. To clear the editorial PR backlog, I'm going to squash and merge this today though since it is indeed editorial. |
|
|
||
| <p>This Track Buffer then flows to a green box labeled Audio Decoder, which | ||
| then flows through a closed switch, which then also continues to the same | ||
| indicator (green circle with an X) labeled Audio Device previously mentioned in |
There was a problem hiding this comment.
I think we could rephrase this to describe the purpose of "indicator (green circle with an X)". In a flow chart (I just looked this up...) the symbol is a "summing junction" which suggests that any enabled audio tracks are summed, i.e., mixed to form the output audio. This corresponds with definition of AudioTrack.
Unless you prefer to do it, I could raise a PR with suggested text along those lines.
There was a problem hiding this comment.
Good catch. PR sounds good to me if you have time. I've filed an issue to ensure this gets done one way or the other :)
#314
Fixes a typo (one of the flows was described incorrectly as going to a
Video Decoder, not an Audio Decoder), and fixes a couple omissions of
mentions of track buffer process indications between SourceBuffer 2
and Video Decoder, and between SourceBuffer 3 and Audio Decoder.
(I found these issues while investigating #307 and reviewing #308.)