Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update translations for v4.2.3 #1139

Merged
merged 1 commit into from
Jun 22, 2020
Merged

update translations for v4.2.3 #1139

merged 1 commit into from
Jun 22, 2020

Conversation

rdeltour
Copy link
Member

@rdeltour rdeltour commented May 4, 2020

This PR contains the updated translations for v4.2.3. It can be updated with newer translations until v4.2.3 is published.

The updated files have been pulled with ./src/build/transifex-pull.sh --all

@tofi86 :

  • I manually reviewed the messages in the Transifex UI to delete the translations which only contained a copy of the English message (to revert the side effect introduced in fix: harmonize quotes usage in messages #1132).
  • the pull command post-processing gives me a sed error (sed: RE error: illegal byte sequence) for the com/thaiopensource/relaxng/pattern/resources/Messages_fr.properties properties. I haven't looked deeper, but it may result in a corrupted or wrongly-escaped property file. Rings any bell?

@rdeltour rdeltour added this to the 4.2.3 milestone May 4, 2020
@rdeltour rdeltour requested a review from tofi86 May 4, 2020 08:38
@rdeltour rdeltour self-assigned this May 4, 2020
@rdeltour rdeltour merged commit 8eb1677 into master Jun 22, 2020
@rdeltour rdeltour deleted the i18n/v4.2.3 branch June 22, 2020 08:41
@tofi86
Copy link
Collaborator

tofi86 commented Jun 22, 2020

@rdeltour sorry for not beeing able to review this or answer your question :-( You still have problems with the tx pull?

@rdeltour
Copy link
Member Author

@tofi86 no worries 😊
Yes the tx pul wasn’t able to properly encode one properties file… for now I manually edited it, and will see if the problem persists in the next pull 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants