Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate and wrong warning for multiple nav landmarks #734

Closed
tofi86 opened this issue Dec 30, 2016 · 1 comment
Closed

Duplicate and wrong warning for multiple nav landmarks #734

tofi86 opened this issue Dec 30, 2016 · 1 comment
Assignees
@tofi86
Labels
status: has PR The issue is being processed in a pull request type: bug The issue describes a bug
Milestone
4.1.0

Comments

@tofi86
Copy link
Collaborator

tofi86 commented Dec 30, 2016 •
edited
Loading

At the moment, when an EPUB has >1 landmarks nav entries, the following messages are triggered:

ERROR(RSC-005): /Users/tofi/Downloads/BookOfTexas_ePub3_v3.epub/OEBPS/6-TOC.xhtml(8,7): Error while parsing file 'Multiple occurrences of the 'landmarks' nav element'.
USAGE(ACC-008): /Users/tofi/Downloads/BookOfTexas_ePub3_v3.epub(-1,-1): Navigation Document has no 'landmarks nav' element.

ACC-008 is just wrong in this case.

refs #457
@tofi86 tofi86 added type: improvement The issue suggests an improvement of an existing feature type: feature The issue describes a new feature request labels Dec 30, 2016
@tofi86 tofi86 added this to the Next milestone Dec 30, 2016
@tofi86 tofi86 self-assigned this Dec 30, 2016
@tofi86 tofi86 changed the title Issue a warning for multiple nav landmarks Duplicate and wrong warning for multiple nav landmarks Dec 31, 2016
@tofi86 tofi86 added type: bug The issue describes a bug and removed type: improvement The issue suggests an improvement of an existing feature type: feature The issue describes a new feature request labels Dec 31, 2016
tofi86 added a commit that referenced this issue Jan 1, 2017
@tofi86
move and fix ACC-008 check // fixes #734
8587fc2
tofi86 added a commit that referenced this issue Jan 1, 2017
@tofi86
fix test cases for ACC-008 changes
07a15cc 
refs 8587fc2
refs #734
This was referenced Jan 1, 2017
Merged
Closed
@tofi86
Copy link
Collaborator Author

tofi86 commented Jan 1, 2017

has been fixed with PullRequest #735

@tofi86 tofi86 added the status: has PR The issue is being processed in a pull request label Jan 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tofi86 tofi86

Labels
status: has PR The issue is being processed in a pull request type: bug The issue describes a bug
Projects
None yet
Milestone
4.1.0
Development

No branches or pull requests
1 participant
@tofi86