Change format of generated test files to be comparable #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spectranaut
approved these changes
Nov 18, 2020
| @@ -6,18 +6,81 @@ | |||
| <link rel="help" href="https://w3c.github.io/aria/#checkbox"> | |||
| <link rel="help" href="https://w3c.github.io/aria/#aria-checked"> | |||
|
|
|||
| <script src="scripts.js"></script> | |||
| <script> | |||
| var scripts = { | |||
There was a problem hiding this comment.
this is a bit strange, it might be nice to not include it if it's not necessary. but because they are generate files I suppose it doesn't matter, and this is not blocking.
|
@rmeritz or @spectranaut, as a test developer, is there anything I have to do to comply with these changes for PRs that haven't yet been merged? E.g. #330. |
|
@jscholes - Nope these changes don't affect anything about the test writing. Once this PR is merged when you regenerate the generated files will have a different format but you don't need to worry about it at all. Thanks for checking though. |
They are needed to generate the reivew pages.
I think it once running once for all PRs and once for all PR targets (which is to support forks). And then the two commits were collbering each other.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview Tests
See the annotated file in this issue for more infomation about the reason for this change: #305