Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create tests for APG design pattern example: Tri-State Checkbox #330

Merged
merged 27 commits into from
Mar 25, 2021
Merged

Create tests for APG design pattern example: Tri-State Checkbox #330

merged 27 commits into from
Mar 25, 2021

Conversation

jscholes
Copy link
Contributor

@jscholes jscholes commented Nov 10, 2020 •
edited by github-actions bot
Loading

Preview Tests

Resolves #322.

jscholes and others added 13 commits November 10, 2020 14:43
@jscholes
Add tri-state checkbox APG example with modified CSS/JS references
335dada 
The following CSS and JS references have been removed:

* `../../css/core.css`
* `../../js/examples.js`
* `../../js/highlight.pack.js`
* `../../js/app.js`

The following references have been modified to match the directory structure of code once added to the aria-at repo:

* `../css/checkbox.css` -> `css/checkbox.css`

The reference to https://www.w3.org/StyleSheets/TR/2016/base.css has been maintained.
@jscholes
Example: remove 'Related Links' nav
91715c7
@jscholes
Example: update pattern href
e0e46f5
@jscholes
Example: remove links to similar examples
6f70c60
@jscholes
Example: remove 'Keyboard Support', 'Role, Property, State, and Tabin…
617bda7 
…dex Attributes' and source code sections
@jscholes
Example: remove footer nav
e47c32a
@jscholes
Example: add links before and after the tri-state checkbox for use in…
4357a2e 
… setup scripts

The links are implemented with an `href` attribute which references their own ID.  This pattern creates links which are valid (according to the W3C's validator) but don't move the keyboard focus if accidentally activated by a tester.
@jscholes
Add references.csv
dfea276
@jscholes
Add commands.csv
e9488d8
@jscholes
Example: change page title and main heading text to match wording of …
9747270 
…tests
@jscholes
Add supporting setup scripts for tests
78f122c
@jscholes
Add tests.csv
f9e6472
@jscholes @actions-user
Generate test and review files automatically
0d252b2
@jscholes jscholes marked this pull request as ready for review November 12, 2020 20:08
@jscholes jscholes requested a review from IsaDC November 12, 2020 20:08
@jscholes jscholes mentioned this pull request Nov 18, 2020
Merged
@jscholes jscholes mentioned this pull request Jan 5, 2021
Closed
@jscholes
Copy link
Contributor Author

Review notes:

  1. There are no buttons to open the example on the review page, as these weren't included on the page template at the time this PR was filed. Buttons to open test pages were added in commit ec299fc.
  2. The example in the reference directory isn't timestamped, again because the script and pattern for this were added later than this PR (in 4d77ba2).

Both of the above can easily be fixed by merging master into this tests branch, adding the timestamped directory and then allowing the test pages to be regenerated. But there are currently merge conflicts in files that haven't been manually touched during creation of this PR, such as the unrelated menubar editor tests.

@jscholes jscholes mentioned this pull request Feb 2, 2021
Open
@mcking65 mcking65 merged commit e7212c4 into master Mar 25, 2021
@mcking65 mcking65 deleted the tests/checkbox-tri-state branch March 25, 2021 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IsaDC IsaDC IsaDC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create tests for APG design pattern example: Tri-State Checkbox
3 participants
@jscholes @IsaDC @mcking65