Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy results from advanced phase #976

Conversation

howard-e
Copy link
Contributor

@howard-e howard-e commented Mar 20, 2024

Problem

During the current results copy process, only the results from the 'next' available older TestPlanVersion is considered when preserving results during an update on the DataManagement page.

That is, if there is an older TestPlanVersion in CANDIDATE and a newly imported TestPlanVersion in RD is being promoted to DRAFT, it will not attempt to copy the results from the CANDIDATE TestPlanVersion. It WOULD copy the results if the older TestPlanVersion was in DRAFT however.

This creates an issue for ease of testing and preservation of future results capture. It would force testers to have to re-run entire suites and compare against past results manually.

Solution

This PR now allows for results to be copied from advanced phases which are 1+ phases away from the current. ie. when promoting to DRAFT from RD, reports could be copied from the latest imported CANDIDATE or RECOMMENDED TestPlanVersions if applicable.

This addresses the following from #935:

Functionality to support copying results when a TestPlanVersion is in an advanced phase.

Dependent on #974

@howard-e howard-e changed the title WIP: Copy results from advanced phase Copy results from advanced phase Mar 21, 2024
@howard-e howard-e marked this pull request as ready for review March 25, 2024 14:26
Copy link
Collaborator

@Paul-Clue Paul-Clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's working fine in my local setup, and the code looks good to me!

Base automatically changed from unmarkCopiedTestPlanReportsAsFinal to supportPreservingResultsWithCommandsChanged April 3, 2024 20:41
* WIP

* Adding support for copying from old test plan report when adding to the test queue

* Address PR feedback
@howard-e howard-e merged commit f0afc67 into supportPreservingResultsWithCommandsChanged Apr 8, 2024
2 checks passed
@howard-e howard-e deleted the copyResultsFromAdvancedPhase branch April 8, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants