-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copy results from advanced phase #976
Merged
howard-e
merged 20 commits into
supportPreservingResultsWithCommandsChanged
from
copyResultsFromAdvancedPhase
Apr 8, 2024
Merged
Copy results from advanced phase #976
howard-e
merged 20 commits into
supportPreservingResultsWithCommandsChanged
from
copyResultsFromAdvancedPhase
Apr 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… updated for a test
…t won't be needed depending on when this change goes to production
…uring version update process
…kCopiedTestPlanReportsAsFinal
…n TestPlanVersion being updated from DRAFT
…kCopiedTestPlanReportsAsFinal
…kCopiedTestPlanReportsAsFinal
…kCopiedTestPlanReportsAsFinal
Paul-Clue
approved these changes
Mar 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's working fine in my local setup, and the code looks good to me!
…kCopiedTestPlanReportsAsFinal
Base automatically changed from
unmarkCopiedTestPlanReportsAsFinal
to
supportPreservingResultsWithCommandsChanged
April 3, 2024 20:41
…esultsFromAdvancedPhase
* WIP * Adding support for copying from old test plan report when adding to the test queue * Address PR feedback
f0afc67
into
supportPreservingResultsWithCommandsChanged
2 checks passed
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
During the current results copy process, only the results from the 'next' available older TestPlanVersion is considered when preserving results during an update on the DataManagement page.
That is, if there is an older
TestPlanVersion
inCANDIDATE
and a newly importedTestPlanVersion
inRD
is being promoted toDRAFT
, it will not attempt to copy the results from theCANDIDATE
TestPlanVersion
. It WOULD copy the results if the olderTestPlanVersion
was inDRAFT
however.This creates an issue for ease of testing and preservation of future results capture. It would force testers to have to re-run entire suites and compare against past results manually.
Solution
This PR now allows for results to be copied from advanced phases which are 1+ phases away from the current. ie. when promoting to
DRAFT
fromRD
, reports could be copied from the latest importedCANDIDATE
orRECOMMENDED
TestPlanVersions if applicable.This addresses the following from #935:
Dependent on #974