Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improving the test results copy functionality #935

Closed
5 tasks done
howard-e opened this issue Feb 26, 2024 · 2 comments
Closed
5 tasks done

Improving the test results copy functionality #935

howard-e opened this issue Feb 26, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@howard-e
Copy link
Contributor

howard-e commented Feb 26, 2024 •
edited
Loading

Currently, the app supports copying results for reports when updating a TestPlanVersion's phase under the following conditions:

  • When the earlier TestPlanReports' data to be used is a part of a DRAFT TestPlanVersion
    • Note that if a report is marked as final while in DRAFT, when the newer report is included and copies over the results, it also copies the marked final status and isn't unmarked in the Test Queue to make it clear that those results have been copied over.
  • Assertion text for a command for a test has not changed.

The above creates the following problems when:

  • A TestPlanVersion is in an advanced phase (CANDIDATE or RECOMMENDED) and it has results which could be copied over into a new version, to make subsequent test collection and review cycles easier
  • When assertion text has changed in the instance of just a typo being fixed and now several tests using that assertion has to be completely copied over again.
  • When commands have been added, removed or edited and now several unrelated results for other commands in that test have to be completely copied over again

The suggestions as noted through recent CG discussions and functional reviews is that the following needs to happen to support a better results copying process between TestPlanVersions and their TestPlanReports:

Note
@howard-e howard-e added the enhancement New feature or request label Feb 26, 2024
@howard-e
Copy link
Contributor Author

During the tests comparison process between versions, relax constraints to allow situations such as typos to be considered "the same".

Resolved by #956

@howard-e
Copy link
Contributor Author

From CG discussion on Mar 13:

  • Need to account for when commands have been added or removed from a test
  • Need to be able to pull older results when also adding an individual Test Plan Report to the Test Queue instead instead of just providing that functionality during the advance process from the Data Management page

This was referenced Mar 19, 2024
Merged
Merged
Merged
Merged
@howard-e howard-e mentioned this issue Apr 4, 2024
Closed
howard-e added a commit that referenced this issue Apr 10, 2024
@howard-e
feat: Enhance copy results functionality (#967)
3a4d3c8 
Addresses #935 by resolving several issues identified with the current test results copying process.

* Supports preserving results of a test even when a command has been removed, added or updated between test versions.
* Previously, if an older test plan report was marked as final, the newly created test plan report would also be marked as final. Instead, the newly created test plan report will always be created as final to allow test administrators to be able to make changes if required and mark as final again, if appropriate.
* Adds support for copying results from an advanced phase instead of just the phase being overwritten. For eg. results would only be copied from DRAFT if the older version is currently in DRAFT but wouldn't have if the older version was in CANDIDATE. This is now being done.
* Now allows results to be copied if adding to Test Queue for a specific combination and an older version exists with that combination that also has valid results. Previously this was only supported by the using the 'Advance to Phase' button on the Data Management page. But if for whatever reason, a report's combination was missed there would be no way to now get that result back. This allows for the result to be included again when adding to the Test Queue with a dialog pop up for an admin to confirm if they want to make a new report or copy the old results (if any exists).
@howard-e howard-e mentioned this issue Apr 29, 2024
Merged
@ccanash ccanash moved this from In staging/sandbox to In production / Completed in MVP support of ARIA-AT Working Mode by ARIA-AT App - 2023 H1 Project Apr 30, 2024
@ccanash ccanash closed this as completed Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
No open projects
MVP support of ARIA-AT Working Mode by ARIA-AT App - 2023 H1 Project
Status: In production / Completed
Milestone
No milestone
Development

No branches or pull requests
2 participants
@howard-e @ccanash